Created attachment 652955[details]
Engine log
Description of problem:
When importing a VM, the frontend forcibly sends collapseSnapshots=true if the imported VM already exists in the snapshot or Clone All is checked, regardless of whether the checkbox for Collapse All Snapshots is checked or not.
Version-Release number of selected component (if applicable):
Reproduced on upstream oVirt, change-id I7088b94cd716bb93b2a4813963a980f4eab9e597 (commit d099b397ef800917d06e173c93aba81cde3a5a9a).
How reproducible:
100%
Steps to Reproduce:
1. Create an NFS DC
2. Create a storage domain on the DC
3. Create a VM with a disk
4. Take a snapshot of the VM
5. Create an export domain
6. Export the VM
7. Import the same VM. Make sure that "Collapse All Snapshots" IS NOT CHECKED.
Actual results:
Although the checkbox was not checked, import is run with collapseAllSnapshots=ture, and the imported VM's snapshot is collapsed.
Expected results:
Need to understand if the described behaviour (i.e., overiding Collapse All Snapshots) is desired or not.
If it isn't - remove it.
If it is - mark the checkbox as checked, and grey it out, so the user will not have the misconception that he can control this behaviour.
Additional info:
Further analysis - this checkbox is a per VM property, not a global one, so the screen should probably be changed (a box per VM probably?).
Removing devel-ack and pm-ack so this bug can be re-eveluated and a direction decided.
Verified on is9.1.
Importing a VM without collapse snapshots imports the vm with the snapshot as expected. Attempting to import a VM more than once shows the checkboxes for Clone and Collapse for that vm as on and greyed out, and the import collapses the snapshots.
Created attachment 652955 [details] Engine log Description of problem: When importing a VM, the frontend forcibly sends collapseSnapshots=true if the imported VM already exists in the snapshot or Clone All is checked, regardless of whether the checkbox for Collapse All Snapshots is checked or not. Version-Release number of selected component (if applicable): Reproduced on upstream oVirt, change-id I7088b94cd716bb93b2a4813963a980f4eab9e597 (commit d099b397ef800917d06e173c93aba81cde3a5a9a). How reproducible: 100% Steps to Reproduce: 1. Create an NFS DC 2. Create a storage domain on the DC 3. Create a VM with a disk 4. Take a snapshot of the VM 5. Create an export domain 6. Export the VM 7. Import the same VM. Make sure that "Collapse All Snapshots" IS NOT CHECKED. Actual results: Although the checkbox was not checked, import is run with collapseAllSnapshots=ture, and the imported VM's snapshot is collapsed. Expected results: Need to understand if the described behaviour (i.e., overiding Collapse All Snapshots) is desired or not. If it isn't - remove it. If it is - mark the checkbox as checked, and grey it out, so the user will not have the misconception that he can control this behaviour. Additional info: