Bug 880882 (php-JsonSchema)
| Summary: | Review Request: php-JsonSchema - PHP implementation of JSON schema | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | fedora, notting, package-review | ||||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2012-12-26 04:58:27 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Shawn Iwinski
2012-11-28 02:51:57 UTC
NOTE: Tests not included or run because Composer (http://getcomposer.org/) required You can simply run the tests using a trivial PSR0 autoload.php
<?php
spl_autoload_register(function ($class) {
$src = str_replace('\\', '/', $class).'.php';
require_once $src;
});
And
phpunit --bootstrap=autoload.php -d include_path="../src/:.:/usr/share/pear" .
(In reply to comment #2) Thanks for the tip. Tests are now run in %check. Changelog: - Updated to upstream version 1.2.2 - Added php-ctype require - Added PSR-0 autoloader for tests - Added %check Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-JsonSchema.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-JsonSchema-1.2.2-1.fc17.src.rpm Sorry. Build failure in Koji. Will fix soon. Changelog: - Fixed failing Mock/Koji builds - Removed "docs" directory from %doc Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-JsonSchema.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-JsonSchema-1.2.2-2.fc17.src.rpm Created attachment 663620 [details]
phpci-src.log
Created attachment 663622 [details]
phpci-tests.log
Created attachment 663624 [details]
php-JsonSchema-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 880882
All seems fine. No blocker. === APPROVED === THANKS for the review and tips! New Package SCM Request ======================= Package Name: php-JsonSchema Short Description: PHP implementation of JSON schema Owners: siwinski Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). php-JsonSchema-1.2.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-JsonSchema-1.2.2-2.fc18 php-JsonSchema-1.2.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-JsonSchema-1.2.2-2.fc17 php-JsonSchema-1.2.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-JsonSchema-1.2.2-2.el6 php-JsonSchema-1.2.2-2.fc18 has been pushed to the Fedora 18 testing repository. php-JsonSchema-1.2.2-2.fc17 has been pushed to the Fedora 17 stable repository. php-JsonSchema-1.2.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. php-JsonSchema-1.2.2-2.fc18 has been pushed to the Fedora 18 stable repository. |