Bug 880993

Summary: XML tags are improperly nested or incorrectly closed for volume top commands in some cases
Product: [Community] GlusterFS Reporter: Timothy Asir <tjeyasin>
Component: cliAssignee: Avra Sengupta <asengupt>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: medium    
Version: pre-releaseCC: amarts, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-24 17:36:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Timothy Asir 2012-11-28 11:03:25 UTC
The brick tags in the xml output of volume top commands are improperly nested or incorrectly closed when a brick does not contain any file(s)

Version: 3.4.0qa2

Sample results:

[root@dhcp159-18 vdsm.test6]# gluster volume top music2 open nfs --xml | xmllint --format -
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr/>
  <volTop>
    <brickCount>2</brickCount>
    <topOp>1</topOp>
    <brick>
      <name>localhost</name>
      <members>0</members>
      <currentOpen>0</currentOpen>
      <maxOpen>1</maxOpen>
      <maxOpenTime>2012-11-28 05:09:19.576519</maxOpenTime>
      <brick>
        <name>10.16.159.17</name>
        <members>0</members>
        <currentOpen>0</currentOpen>
        <maxOpen>0</maxOpen>
        <maxOpenTime>N/A</maxOpenTime>
      </brick>
    </brick>
  </volTop>
</cliOutput>

Comment 1 Vijay Bellur 2012-12-04 04:42:21 UTC
CHANGE: http://review.gluster.org/4262 (cli: fix incorrect xml output of brick tag.) merged in master by Vijay Bellur (vbellur)