Bug 881338

Summary:	TypeError: __new__() takes exactly 7 arguments (6 given)
Product:	[Fedora] Fedora	Reporter:	Freddy Willemsen <freddy>
Component:	fedup	Assignee:	Will Woods <wwoods>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	17	CC:	npatil, olivier.levillain, pablomg+fedora, thomas.mey, wwoods
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-03 07:26:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Freddy Willemsen 2012-11-28 18:22:09 UTC

Description of problem:

sudo fedup-cli --network 18 --debuglog fedupdebug.log --instrepo=http://tflink.fedorapeople.org/fedup/f18-upgrade/x86_64

...

Traceback (most recent call last):
  File "/bin/fedup-cli", line 285, in <module>
    main(args)
  File "/bin/fedup-cli", line 257, in main
    prep_boot(kernel, initrd)
  File "/usr/lib/python2.7/site-packages/fedup/download.py", line 373, in prep_boot
    modify_bootloader(kernel, initrd)
  File "/usr/lib/python2.7/site-packages/fedup/download.py", line 356, in modify_bootloader
    for e in bootloader.get_entries():
  File "/usr/lib/python2.7/site-packages/fedup/grubby.py", line 69, in get_entries
    ents.append(self.get_entry(n))
  File "/usr/lib/python2.7/site-packages/fedup/grubby.py", line 63, in get_entry
    return GrubbyEntry(**info)
TypeError: __new__() takes exactly 7 arguments (6 given)



Version-Release number of selected component (if applicable):
Fedora 17, fully updated
fedup-0.7.1-1.fc17

How reproducible:
sudo fedup-cli --network 18 --debuglog fedupdebug.log --instrepo=http://tflink.fedorapeople.org/fedup/f18-upgrade/x86_64


Steps to Reproduce:
1. update Fedora 17 
2. install fedup (yum --enablerepo=updates-testing install fedup)
3. Run fedup-cli: sudo fedup-cli --network 18 --debuglog fedupdebug.log --instrepo=http://tflink.fedorapeople.org/fedup/f18-upgrade/x86_64

  
Actual results:
TypeError: __new__() takes exactly 7 arguments (6 given)

Expected results:
Upgraded system


Additional info:
Since I saw the grubby error I figured it might have to do with the fact that I am not using the initrd part (root=/dev/sda1 rootfstype=ext4).

If I revert that change fedup-cli returns no errors.

Comment 1 Olivier LEVILLAIN 2012-12-01 18:08:50 UTC

Exactly the same error for me.
In my context, I have fedup once with no problem then when I rebooted and ran the system upgrage in GRUB2, the system remained stuck for half an hour after the bars at the bottom of the screen "completed". I had to restart my PC.
Then Fedora 18 crashed at boot (unable to mount FS).
I tried to restart the system upgrade in grub with no effect.
So I restarted on my "old" F17 and tried to re run fedup and now I have this error.
When I look at my grub config, the only difference betweenF17 and F18 is that there is no initrd line in F18.

Comment 2 Will Woods 2012-12-03 20:31:36 UTC

Yup, good catch - the traceback here is because fedup's grubby module assumes that any boot entry will have all six items (index, root, args, kernel, initrd, title).. and sometimes that isn't true.

The fix for this is pretty simple. Should be in git shortly.

Comment 3 Will Woods 2012-12-03 22:26:02 UTC

*** Bug 882437 has been marked as a duplicate of this bug. ***

Comment 4 Will Woods 2012-12-04 19:00:39 UTC

*** Bug 883258 has been marked as a duplicate of this bug. ***

Comment 5 Will Woods 2012-12-05 16:58:59 UTC

*** Bug 883659 has been marked as a duplicate of this bug. ***

Comment 6 Will Woods 2012-12-05 16:59:39 UTC

*** Bug 883660 has been marked as a duplicate of this bug. ***

Comment 7 Fedora Update System 2012-12-21 04:49:28 UTC

fedup-0.7.2-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/fedup-0.7.2-1.fc17

Comment 8 Fedora Update System 2012-12-21 12:10:00 UTC

Package fedup-0.7.2-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing fedup-0.7.2-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-20801/fedup-0.7.2-1.fc17
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2013-01-03 07:26:41 UTC

fedup-0.7.2-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.