Bug 882713
| Summary: | Review Request: gdigi - utility to control Digitech effects pedal on Linux | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mauro Carvalho Chehab <mchehab> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hdegoede, lwang, notting, package-review |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-12 00:17:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mauro Carvalho Chehab
2012-12-02 20:40:51 UTC
Hi, I'll take this one for review. Full review done: Good: ===== - package meets naming guidelines - package meets packaging guidelines - license (GPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime Needs work: =========== - rpmlint checks return: gdigi.x86_64: W: incoherent-version-in-changelog 0.3.0-20121202git.1.fc17 ['0.3.0-20121202git.1.fc18', '0.3.0-20121202git.1'] gdigi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gdigi-0.3.0/gtkknob.c gdigi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gdigi-0.3.0/gtkknob.h Please fix the incoherent changelog issue -please drop the "Requires: expat gtk3", rpm automatically detects this dependecies based on soname: rpm -qp --requires ~/rpmbuild/RPMS/x86_64/gdigi-0.3.0-20121202git.1.fc18.x86_64.rpm <snip> libexpat.so.1()(64bit) <snip> libgtk-3.so.0()(64bit) -gdigi has a .desktop file so this applies: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files Thus there must be a: desktop-file-validate %{buildroot}/%{_datadir}/applications/foo.desktop line at the end of the %install section -please drop the BuildRoot, rm -rf %{buildroot} in %install and %clean section they are no longer nescessary. -please drop the %defattr, they are no longer necessary -please do not gzip the manpage before install rpmbuild will take care of compressing it in its install destination, and if we ever decide to move from gzip to for example bz2, then rpmbuild will automatically do the right thing. Please provide a new version fixing the needs work issues, with the Release field bumped, and a specfile changelog entry describing the changes made. Thanks & Regards, Hans (In reply to comment #1) > Hi, > > I'll take this one for review. Thank you for the review! > Needs work: > =========== > - rpmlint checks return: > gdigi.x86_64: W: incoherent-version-in-changelog 0.3.0-20121202git.1.fc17 > ['0.3.0-20121202git.1.fc18', '0.3.0-20121202git.1'] Fixed. Compiled it This time at F18 Beta. > gdigi-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/gdigi-0.3.0/gtkknob.c > gdigi-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/gdigi-0.3.0/gtkknob.h I emailed to the application author for him to fix it upstream. I'll bump version when the fix will be there. > Please provide a new version fixing the needs work issues, with the Release > field bumped, and a specfile changelog entry describing the changes made. Done: http://mchehab.fedorapeople.org/gdigi/gdigi.spec http://mchehab.fedorapeople.org/gdigi/gdigi-0.3.0-20121202git.2.fc18.src.rpm (In reply to comment #2) > Done: > > http://mchehab.fedorapeople.org/gdigi/gdigi.spec > http://mchehab.fedorapeople.org/gdigi/gdigi-0.3.0-20121202git.2.fc18.src.rpm Looks good now -> Approved! Note you did forget to drop the "BuildRoot: ..." from the specfile, please drop this before import. Regards, Hans (In reply to comment #3) > (In reply to comment #2) > > Done: > > > > http://mchehab.fedorapeople.org/gdigi/gdigi.spec > > http://mchehab.fedorapeople.org/gdigi/gdigi-0.3.0-20121202git.2.fc18.src.rpm > > Looks good now -> Approved! Thank you! > Note you did forget to drop the "BuildRoot: ..." from the specfile, please > drop this before import. Done: http://mchehab.fedorapeople.org/gdigi/gdigi.spec New Package SCM Request ======================= Package Name: gdigi Short Description: Utility to control DigiTech effect pedals Owners: mchehab Branches: f17 f18 rawhide InitialCC: mchehab Git done (by process-git-requests). gdigi-0.3.0-20121203git.2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gdigi-0.3.0-20121203git.2.fc17 gdigi-0.3.0-20121203git.1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gdigi-0.3.0-20121203git.1.fc18 gdigi-0.3.0-20121203git.1.fc18 has been pushed to the Fedora 18 testing repository. gdigi-0.3.0-20121203git.1.fc18 has been pushed to the Fedora 18 stable repository. gdigi-0.3.0-20121203git.2.fc17 has been pushed to the Fedora 17 stable repository. |