Bug 883076

Summary: installer allows reformat of existing (non-swap) device without setting a mountpoint
Product: [Fedora] Fedora Reporter: Michael Cronenworth <mike>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: anaconda-maint-list, g.kaviyarasu, jonathan, sbueno, stephent98, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-08 04:30:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot showing duplicate entries for 500 MB device
none
anaconda-tb-all.log corresponding to reproducer in Comment 1 none

Description Michael Cronenworth 2012-12-03 17:54:55 UTC
Description of problem: A duplicate UI widget is created when you add a mount point to a partition that does not have one in a custom partitioning scheme.


Version-Release number of selected component (if applicable): F18 Beta


How reproducible: Always


Steps to Reproduce:
-I checked "I don't need help; let me customize disk partitioning."
-Clicked on "Reclaim space" button.
-Clicked on plus button on existing F18 installation.
-Clicked on the "Boot" 500MB partition.
-Clicked on "Customize..."
-Clicked on "Reformat"
-Clicked on "Apply Changes"
-Click on plus button on new F18 installation.
-Click on "ext4 500MB" partition.
-Type in "/boot" into Mount Point.
-Click "Apply Changes" 

At this point a "Boot 500MB" partition is added, but the old "ext4 500MB" partition line is still displayed.

If you navigate back to the old F18 installation area, and then back to the new F18 install partitions the "ext4 500MB" partition disappears.


Actual results: Two UI items for one partition.


Expected results: One UI item.

Comment 1 Steve Tyler 2012-12-03 18:31:20 UTC
Created attachment 656885 [details]
screenshot showing duplicate entries for 500 MB device

I always thought that was a feature ... :-)

Create an empty 12 GB disk image.
Boot from the installer DVD.
From Manual Partitioning, auto-create mount points.
Complete minimal install.

Reboot into installer.
Proceed to Manual Partitioning.
Select Boot.
Check Reformat.
Click Apply Changes.
Under the New ... Installation expander, click ext4.
Enter /boot for the mount point.
Click Apply Changes.
A duplicate 500 MB entry is displayed.

Tested with:
$ qemu-img create f18-test-2.img 12G
$ qemu-kvm -m 2048 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/Final/Fedora-18-Beta-x86_64-DVD.iso -usb -vga qxl -boot menu=on -usbdevice mouse

Comment 2 Steve Tyler 2012-12-03 18:51:20 UTC
Created attachment 656901 [details]
anaconda-tb-all.log corresponding to reproducer in Comment 1

Captured after returning to Installation Summary with:
# pkill -USR2 -o anaconda

Comment 3 David Lehman 2012-12-03 19:54:40 UTC
(In reply to comment #1)
> I always thought that was a feature ... :-)

That depends. If you don't mark the existing device to be reformatted, it will stay in both the old installation and the new one since it could still possibly be used by both. If you do mark it for reformat it should no longer remain in the old installation since reformatting it presumably makes it no longer viable as part of an older installation.


The main bug here is actually allowing you to mark existing devices for reformat without also making sure you have set a valid mountpoint.

Comment 4 Steve Tyler 2012-12-03 20:09:26 UTC
OK. If I check Reformat and enter "/" before clicking Apply Changes, no duplicate is listed under New ... Installation.

It might be a minor convenience to auto-fill the mount point and label with the existing ones, if they are set ...

Comment 5 Fedora Update System 2012-12-06 01:55:00 UTC
anaconda-18.36-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/anaconda-18.36-1.fc18

Comment 6 Fedora Update System 2012-12-06 20:17:27 UTC
Package anaconda-18.36-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-18.36-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-19870/anaconda-18.36-1.fc18
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2012-12-08 04:30:11 UTC
anaconda-18.36-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.