Bug 883417

Summary: notifier.conf: incomplete validation for several parameters.
Product: Red Hat Enterprise Virtualization Manager Reporter: Ilanit Stein <istein>
Component: ovirt-engine-notification-serviceAssignee: Noam Slomianko <nslomian>
Status: CLOSED CURRENTRELEASE QA Contact: Ilanit Stein <istein>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.1.0CC: bazulay, dfediuck, dyasny, iheim, pstehlik, Rhev-m-bugs, sgrinber, ykaul, yzaslavs
Target Milestone: ---   
Target Release: 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: sf8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 915537    

Description Ilanit Stein 2012-12-04 14:53:33 UTC 
Description of problem:
Following parameters settings do not generate error after notifier service restart, as expected:
1) MAIL_USER=-111 (negative number)
2) MAIL_PORT=123 (wrong number)
3) HTML_MESSAGE_FORMAT=blabla (should be true/false)

Version-Release number of selected component (if applicable):
SI24.5

How reproducible:
always
Comment 1 Yaniv Kaul 2012-12-04 14:54:55 UTC 
(In reply to comment #0)
> Description of problem:
> Following parameters settings do not generate error after notifier service
> restart, as expected:
> 1) MAIL_USER=-111 (negative number)
> 2) MAIL_PORT=123 (wrong number)

What's wrong with this?

> 3) HTML_MESSAGE_FORMAT=blabla (should be true/false)
> 
> Version-Release number of selected component (if applicable):
> SI24.5
> 
> How reproducible:
> always
Comment 2 Ilanit Stein 2012-12-09 10:10:36 UTC 
The missing validation for these parameters do not point user to the problem of which event notification fail.
Comment 3 Ilanit Stein 2012-12-09 10:14:23 UTC 
The missing validation for these parameters do not point user to the problem
of which event notification fail.
Comment 4 Yair Zaslavsky 2012-12-30 11:19:45 UTC 
We should understand exactly what validation we need for the configuration.
Comment 8 Ilanit Stein 2013-02-28 12:30:58 UTC 
Tested on sf-8:

1) MAIL_USER=-111 (negative number) -> Do not fail notifier restart
2) MAIL_PORT=60000 (wrong number) -> Do not fail notifier restart
3) HTML_MESSAGE_FORMAT=blabla -> Fail notifier service restart:
Error: HTML_MESSAGE_FORMAT must be true or false
                                                           [FAILED]
Comment 9 Doron Fediuck 2013-02-28 14:50:14 UTC 
Ilanit,
Valid mail port range is 1 to 65536. 
So in your case it shouldn't be restarted.

Noam, please check what happened to the user and boolean.
Comment 12 Doron Fediuck 2013-03-03 13:13:18 UTC 
Ilanit,
Both HTML message format and mail port were verified.
We have a fix for the user as a part of bug 885436, so please verify this BZ.
Comment 13 Ilanit Stein 2013-03-13 09:50:28 UTC 
Verified on sf-8, as mentioned in comment 8.
Comment 14 Itamar Heim 2013-06-11 09:49:02 UTC 
3.2 has been released
Comment 15 Itamar Heim 2013-06-11 09:49:19 UTC 
3.2 has been released
Comment 16 Itamar Heim 2013-06-11 09:57:33 UTC 
3.2 has been released