Bug 884112

Description of problem:

Strange crash when finalising references.  Using Bibus 1.5.1 hooked up to LibreOffice writer 3.5.7.2. Inserting references, updating bibliography etc. all works fine however when finalizing progress bar stops at "indexing references".  Launching from a console window produces:

Traceback (most recent call last):
File "/usr/share/bibus/BibFrame.py", line 1632, in onMenuOOoFinalize
self.doc.finalize()
File "/usr/share/bibus/OOo.py", line 96, in finalize
bibOOoPlus.finalize(self,msg.Update)
File "/usr/share/bibus/bibOOo/bibOOoPlus.py", line 105, in finalize
bibOOoBase.finalize(self,messages = messages, cit_sort=cit_sort,cit_fuse=cit_fuse,cit_range=cit_range,cit_separator=cit_separator,cit_order=cit_order,cit_asc=cit_asc)
File "/usr/share/bibus/bibOOo/bibOOoBase.py", line 792, in finalize
self.freezeCitations(messages = messages,**kwds)
File "/usr/share/bibus/bibOOo/bibOOoPlus.py", line 89, in freezeCitations
self.__author_date(messages) # new author-date format
File "/usr/share/bibus/bibOOo/bibOOoPlus.py", line 371, in __author_date
refs=self.getCitations(order='document')# refs in the text order
File "/usr/share/bibus/bibOOo/bibOOoBase.py", line 347, in getCitations
tmplist = [(int(x.getPresentation(False)[lbb:len(x.getPresentation(False))+lba]), x) for x in refs]
ValueError: invalid literal for int() with base 10: 'Davies2011' 

Seems to have been reported on the web http://sourceforge.net/projects/bibus-biblio/forums/forum/380178/topic/4740963 and a patch has been produced http://sourceforge.net/tracker/?func=detail&aid=3323127&group_id=110943&atid=657834 the latest version in the fedora 17 and rawhide repositories appears however to be same version.   

Patching with the patch appears to solve the issue I was having.  

Version-Release number of selected component (if applicable):

1.5.1

How reproducible:

Occurred repeatedly until I patched the relevant file, looking at the code it appeared to try to cast a list of references (strings) to integers. Possibly just a question of which of the two function parameters was being cast. 

Steps to Reproduce:
1.  Install LibreOffice and Bibus
2.  Link Bibus to LibreOffice
2.  Create a document in LibreOffice with a number of references inserted in Bibus
3. Attempt to Finalize the citations (this should replace the temporary markers in the document with formatted citations.)
  
Actual results:

Crash >

Traceback (most recent call last):
File "/usr/share/bibus/BibFrame.py", line 1632, in onMenuOOoFinalize
self.doc.finalize()
File "/usr/share/bibus/OOo.py", line 96, in finalize
bibOOoPlus.finalize(self,msg.Update)
File "/usr/share/bibus/bibOOo/bibOOoPlus.py", line 105, in finalize
bibOOoBase.finalize(self,messages = messages, cit_sort=cit_sort,cit_fuse=cit_fuse,cit_range=cit_range,cit_separator=cit_separator,cit_order=cit_order,cit_asc=cit_asc)
File "/usr/share/bibus/bibOOo/bibOOoBase.py", line 792, in finalize
self.freezeCitations(messages = messages,**kwds)
File "/usr/share/bibus/bibOOo/bibOOoPlus.py", line 89, in freezeCitations
self.__author_date(messages) # new author-date format
File "/usr/share/bibus/bibOOo/bibOOoPlus.py", line 371, in __author_date
refs=self.getCitations(order='document')# refs in the text order
File "/usr/share/bibus/bibOOo/bibOOoBase.py", line 347, in getCitations
tmplist = [(int(x.getPresentation(False)[lbb:len(x.getPresentation(False))+lba]), x) for x in refs]
ValueError: invalid literal for int() with base 10: 'Davies2011'


Expected results:

Opens a new document with the same text and all references exchanged for correctly formatted citations. 

Additional info:

I have fixed my version with the patch (see link above) would be good to have this patched in future versions.