Bug 884347

This bug addressed that the translation files that were pulled down from zanata should be excluded by subsequential Zanata push by default.


+++ This bug was initially created as a clone of Bug #864280 +++

Description of problem:
Implement upload and download from Maven client for documents of type DTD, plain text (.txt), and Open Document Format (odt, ods, odp, etc.).

Expected results:
New commands are available in the Maven plugin to push and pull projects made up of any of the above file types.

Additional info:
Commands will be named 'rawpush' and 'rawpull'

--- Additional comment from David Mason on 2012-11-13 13:08:05 EST ---

Implemented as project type 'raw' that works with standard 'push' and 'pull' commands.

raw project type assumes that all translations are in sibling directories of the source directory, named with locale code and containing the same directory structure as the source directory.

File types to include must be specified when invoking push or pull for a raw project. Specified file types are checked against supported types on the server.

For more details, see the detailed help available in the client.

--- Additional comment from Ding-Yi Chen on 2012-11-28 17:13:34 EST ---

After some further test, it appeared that by default, it mistakenly push the translation files as source as well.

Step to reproduce:
1. push raw files
2. translate the raw file
3. pull raw files without specify -Dzanata.transDir
4. push raw files again

Actual:
The translation files are pushed as source

Expected:
The translation files are NOT pushed as source

--- Additional comment from Ding-Yi Chen on 2012-11-28 17:21:33 EST ---

For push

 mvn zanata:push -Dzanata.projectType=raw -Dzanata.fileType=txt 

and for pull
 
 mvn zanata:pull -Dzanata.projectType=raw -Dzanata.fileType=txt

--- Additional comment from Sean Flanigan on 2012-11-29 09:49:46 EST ---

Whether you push source files, target files, or both, is controlled by pushType, not by the transDir option.  The default value for pushType is 'source'.  

Were the console messages (about what was going to happen) misleading in some way?

--- Additional comment from Ding-Yi Chen on 2012-11-29 14:38:47 EST ---

The default pushType (i.e. without explicitly specified -Dzanata.pushType) is source. Even when I set the -Dzanata.pushType=source, the problem remain the same.

Here is what happended:
Suppose I have README.txt as source. and de, es as locales.

Step 1. mvn zanata:push -Dzanata.projectType=raw -Dzanata.fileType=txt

  README.txt is in server as source.

Step 2. mvn zanata:pull -Dzanata.projectType=raw -Dzanata.fileType=txt
  Following tranlation files are download to local.
  de/README.txt
  es/README.txt

Step 3. mvn zanata:push -Dzanata.projectType=raw -Dzanata.fileType=txt
  Maven client deems all following 3 files as source 
  README.txt
  de/README.txt
  es/README.txt
  
  Now you have 3 files to be translated, which is incorrect.

Pull them down reveals how the situation getting worse:
Step 4. mvn zanata:pull -Dzanata.projectType=raw -Dzanata.fileType=txt
Now you have 
  README.txt
  de/README.txt
  es/README.txt
  de/de/README.txt
  de/es/README.txt
  es/de/README.txt
  es/es/README.txt

--- Additional comment from David Mason on 2012-12-04 14:00:10 EST ---

With current implementation, the source directory must not contain translation directories for raw project type. It should work normally if you change structure to the following, with appropriate directories specified:

  source/README.txt
  de/README.txt
  es/README.txt