Bug 884497

Summary:	Review request: perl-Math-BigInt - Arbitrary size integer/float math package
Product:	[Fedora] Fedora	Reporter:	Marcela Mašláňová <mmaslano>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, ppisar, psabata
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-04 12:46:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marcela Mašláňová 2012-12-06 10:15:38 UTC

SPEC: http://mmaslano.fedorapeople.org/review/perl-Math-BigInt.spec
SRPM: http://mmaslano.fedorapeople.org/review/perl-Math-BigInt-1.997-1.fc18.src.rpm
Description: All operators (including basic math operations) are overloaded if you
declare your big integers as documented. Operations with overloaded
operators preserve the arguments which is exactly what you expect.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4762700

Comment 1 Petr Šabata 2012-12-06 15:56:44 UTC

Issues:

1. This module is provided by the perl package and needs to be subpackaged first to resolve the conflicts.

2. Either buildrequires perl(inc::Module::Install) or explicitly list inc/* dependencies.

3. Buildrequire the package (lib/*) dependencies.  This is required since you run the test suite.

4. The same applies to the test suite dependencies (t/*).

5. Require MODULE_COMPAT macro.

6. Your %__provides_exclude macro doesn't make much sense.  In case you wanted to exlude unversioned Math::BigInt provides, change 'requires' further on the line to 'provides' too.

7. Require undetected runtime deps (Carp, Exporter, File::Spec)

8. The description is an incomplete sentence.

Comment 2 Petr Pisar 2013-12-02 09:02:44 UTC

The CPAN package is older (0.997) than modules in the latest stable perl:

$ corelist -v 5.18.1 |grep Math::BigInt
Math::BigInt                                     1.9991
Math::BigInt::Calc                               1.997
Math::BigInt::CalcEmu                            1.998
Math::BigInt::FastCalc                           0.30
Math::BigInt::Trace                              0.32

I guess there is no point in creating standalone package. Though we could sub-package it.

Comment 3 Marcela Mašláňová 2013-12-04 12:46:03 UTC

Ok, closing now.