Bug 885013
Summary: | Review Request: python-backports-ssl_match_hostname - The ssl.match_hostname() function from Python 3.2 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ian Weller <ian> |
Component: | Package Review | Assignee: | Toshio Ernie Kuratomi <a.badger> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | a.badger, notting, package-review, tcallawa |
Target Milestone: | --- | Flags: | a.badger:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-02-24 08:51:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 956413 |
Description
Ian Weller
2012-12-07 09:57:02 UTC
Seems like if it is copied verbatim from Python 3.2, it is under the Python license, not MIT. You should contact the upstream and try to get them to clarify why they think it is MIT. Mark it as Python and go ahead for now. If it ends up having some valid rationale for being MIT, you can change it without any Freedom concerns. Lifting FE-Legal Scratch build fails for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4784243 + python setup.py build Traceback (most recent call last): File "setup.py", line 4, in <module> from setuptools import setup, find_packages ImportError: No module named setuptools The package python-setuptools is missing from BuildRequires. rm -rf %{buildroot} is an artifact from Fedora 10 and older. Please remove it. Don't know why it is still in the spec template anyway. BuildRequires: python-devel is invalid. Use python2-devel: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires Ping...? There is one bugfix on the bitbucket repo (backport a bugfix from python-3.2.2): https://bitbucket.org/brandon/backports.ssl_match_hostname/commits/450c9250e369696205922932f105822639ddfd83 brandon removed the "+" from the version in the commit after that. Spec URL: http://ianweller.fedorapeople.org/SRPMS/python-backports-ssl_match_hostname/3.2-0.2.a3/python-backports-ssl_match_hostname.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/python-backports-ssl_match_hostname/3.2-0.2.a3/python-backports-ssl_match_hostname-3.2-0.2.a3.fc18.src.rpm Mario, I'm willing to review this since it's needed to unbundle a library from python-urllib3 https://bugzilla.redhat.com/show_bug.cgi?id=907688 . But if you'd like to do it let me know. I'll start on it this afternoon (about six hours from now). ef78d0532f11c4403288a6a4a7e80da2f8924e6b0d662349bb86c09c6fea8b31 backports.ssl_match_hostname-3.2a3.tar.gz Good: * package name meets guidelines * spec file name matches package name * license has been approved. Comment to explain the situation * Spec file is legible * Source matches upstream * No locale files * Not an elf library * No bundled system libraries * Not designed to be relocatable * Package owns all directories it creates * Files listed only once * Permissions set properly * Code, not content * No large docs * Nothing in %doc will affect runtime * Not a GUI application * Does not own files or directories owned by another package at this time. See Notes section below. * All filenames are valid UTF-8 * No scriptlets needed * Builds in koji rpmlint * python-backports-ssl_match_hostname.noarch: W: spelling-error Summary(en_US) ssl -> isl, sol, ssh * python-backports-ssl_match_hostname.noarch: W: spelling-error Summary(en_US) hostname -> host name, host-name, hostage * python-backports-ssl_match_hostname.noarch: W: spelling-error %description -l en_US backport -> back port, back-port, backpacker - All spelling wawrnings are acceptable jargon. False positives in this case. Notes: * Ping upstream with the licensing concerns and request that he adds a License files * note, the backports module seems to be setup as a namespace module. In the future, there may be other packages that attempt to install here. RPM should be able to gracefully handle the directory itself and the __init__.py file should this happen. However, it will not be able to handle the .pyc and .pyo files as those contain timestamps. Should other packages be released by upstream that use the backports module namespace, I recommend shipping a separate python-backports package with the things necessary for the namespace ( %{python_sitelib}/backports and %{python_sitelib}/backports/__init__.py* ) then having all modules within this namespace require it. APPROVED New Package SCM Request ======================= Package Name: python-backports-ssl_match_hostname Short Description: The ssl.match_hostname() function from Python 3.2 Owners: ianweller Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). python-backports-ssl_match_hostname-3.2-0.2.a3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-backports-ssl_match_hostname-3.2-0.2.a3.fc17 python-backports-ssl_match_hostname-3.2-0.2.a3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-backports-ssl_match_hostname-3.2-0.2.a3.fc18 python-backports-ssl_match_hostname-3.2-0.2.a3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-backports-ssl_match_hostname-3.2-0.2.a3.el6 python-backports-ssl_match_hostname-3.2-0.2.a3.el6 has been pushed to the Fedora EPEL 6 testing repository. python-backports-ssl_match_hostname-3.2-0.2.a3.fc18 has been pushed to the Fedora 18 stable repository. python-backports-ssl_match_hostname-3.2-0.2.a3.fc17 has been pushed to the Fedora 17 stable repository. python-backports-ssl_match_hostname-3.2-0.2.a3.el6 has been pushed to the Fedora EPEL 6 stable repository. |