Bug 885081

Summary:	Invalid job handling while restarting CPUs when creating external snapshot
Product:	Red Hat Enterprise Linux 6	Reporter:	Peter Krempa <pkrempa>
Component:	libvirt	Assignee:	Peter Krempa <pkrempa>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.4	CC:	acathrow, dyasny, dyuan, jdenemar, mjenner, mzhan, rwu, whuang, zhpeng
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-0.10.2-12.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-21 07:28:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	888457

Description Peter Krempa 2012-12-07 13:09:28 UTC

Description of problem:
Libvirt uses incorrect async job type when restarting CPUs of the guest after taking an external checkpoint is done.


Version-Release number of selected component (if applicable):
libvirt-0.10.2-11.el6.x86_64


How reproducible:
100%


Steps to Reproduce:
1. start a guest
2. virsh snapshot-create-as guest --memspec=/tmp/test.img
3.
  
Actual results:
$ grep libvirt /var/log/messages | grep warn 
Dec  7 11:14:44 angien libvirtd: 3989: warning : qemuDomainObjEnterMonitorInternal:1005 : This thread seems to be the async job owner; entering monitor without asking for a nested job is dangerous

Expected results:
No warning printed.


Additional info:
This is a bug in a new feature. Fix submitted upstream: http://www.redhat.com/archives/libvir-list/2012-December/msg00331.html

Comment 2 Peter Krempa 2012-12-11 10:34:03 UTC

Fixed upstream:

commit 46b0c93332fb16fd9f64cd9b3bb95a0990145f0c
Author: Peter Krempa <pkrempa>
Date:   Fri Dec 7 11:50:52 2012 +0100

    qemu: Restart CPUs with valid async job type when doing external snapshots
    
    When restarting CPUs after an external snapshot, the restarting function
    was called without the appropriate async job type. This caused that a
    new sync job wasn't created and allowed races in the monitor.

Comment 5 Huang Wenlong 2012-12-13 03:46:47 UTC

Verify this bug with:

libvirt-0.10.2-12.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.340.el6.x86_64

1)start a guest
2. virsh snapshot-create-as guest --memspec=/tmp/test.img
3.  grep libvirt /var/log/messages | grep warn 
there is not warning message like : 
"qemuDomainObjEnterMonitorInternal:1005 : This thread seems to be the async job owner; entering monitor without asking for a nested job is dangerous"

Comment 6 errata-xmlrpc 2013-02-21 07:28:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html