Bug 885157

Summary: CCS/CCP return code
Product: Red Hat Enterprise MRG Reporter: Lubos Trilety <ltrilety>
Component: condor-wallaby-toolsAssignee: Robert Rati <rrati>
Status: CLOSED CURRENTRELEASE QA Contact: Lubos Trilety <ltrilety>
Severity: low Docs Contact:
Priority: low    
Version: DevelopmentCC: esammons, matt, rrati
Target Milestone: 2.3Keywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: condor-wallaby-tools-5.0.5-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-19 16:37:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lubos Trilety 2012-12-07 15:57:59 UTC 
Description of problem:
condor_configure_store/pool returns zero even when there's some problem during run. In case that the problem is not fatal.

e.g. set parameter default value and set must_change to true
# ccs -a -p PAR
Console Connection Established...
Adding the following parameter: PAR with {}
Modifying the following parameter: PAR with {:kind=>"t", :description=>"t", :default_val=>"t", :needsRestart=>false, :level=>0, :must_change=>true}
Couldn't find parameter PAR (Can't set must_change on a parameter with a default value (remove it first):  PAR)
warning: ModifyParam returned non-zero
Modifying the following parameter: PAR with {:annotation=>"t"}

# echo $?
0


Version-Release number of selected component (if applicable):
condor-wallaby-tools-5.0.4-1

How reproducible:
100%

Steps to Reproduce:
see above
  
Actual results:


Expected results:
correct return code

Additional info:
Comment 2 Robert Rati 2013-01-07 19:51:05 UTC 
Fixed upstream on:
BZ885157-return-code
Comment 4 Lubos Trilety 2013-01-10 17:01:10 UTC 
Tested with:
condor-wallaby-tools-5.0.5-1

Tested on:
RHEL6 i386,x86_64
RHEL5 i386,x86_64

It seems return codes are corrected.

# ccs -a -p PAR
Console Connection Established...
Adding the following parameter: PAR with {}
Modifying the following parameter: PAR with {:kind=>"", :description=>"", :default_val=>"some", :needsRestart=>false, :level=>0, :must_change=>true}
Couldn't find parameter PAR (Can't set must_change on a parameter with a default value (remove it first):  PAR)
warning: ModifyParam returned non-zero
Modifying the following parameter: PAR with {:annotation=>""}

# echo $?
1

# ccs -l -f feat
Console Connection Established...
warning:  feature feat does not exist
warning: ShowFeature returned non-zero

# echo $?
127

# ccs -e -p PAR2
Console Connection Established...
Modifying the following parameter: PAR3 with {:kind=>"", :description=>"", :default_val=>"some", :needsRestart=>false, :level=>0, :must_change=>true}
Couldn't find parameter PAR3 (Can't set must_change on a parameter with a default value (remove it first):  PAR3)
warning: ModifyParam returned non-zero
Modifying the following parameter: PAR3 with {:annotation=>""}

# echo $?
1

>>> verified