Bug 885344 (php-guzzle-Guzzle)
| Summary: | Review Request: php-guzzle-Guzzle - PHP HTTP client library and framework for building RESTful web service clients | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, notting, package-review, siwinski | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-02-26 02:34:50 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 885341 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2012-12-08 19:32:13 UTC
Updated to upstream version 3.0.6 Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-guzzle-Guzzle.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-guzzle-Guzzle-3.0.6-1.fc17.src.rpm I notice upstream have release some new versions (latest is 3.1.1) Do you plan an update before review ? (In reply to comment #2) > I notice upstream have release some new versions (latest is 3.1.1) > > Do you plan an update before review ? Yes, I was already planning on trying to update this weekend. Updated to upstream version 3.1.1 Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-guzzle-Guzzle.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-guzzle-Guzzle-3.1.1-1.fc17.src.rpm Created attachment 688768 [details]
phpci.log
Created attachment 688769 [details]
php-guzzle-Guzzle-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 885344
MUST: [!]: Package contains no bundled libraries. provides ...Guzzle/Http/Resources/cacert.pem should use /etc/pki/tls/cert.pem (ca-certificates on fedora, need to check on RHEL) See https://fedoraproject.org/wiki/Features/SharedSystemCertificates In source code Guzzle/Http/Client.php $opts[CURLOPT_CAINFO] = __DIR__ . '/Resources/cacert.pem' This will obviously not work, with current version (should use data_dir). (this is not a library, but for security reason, using a bundled copy seems a very bad idea) SHOULD: [!]: Latest version is packaged. 3.1.2 is released [!]: %check is present and all tests pass. as tests exists in upstream github, please ask upstream to include them in the tarball (In reply to comment #7) > MUST: > > [!]: Package contains no bundled libraries. > provides ...Guzzle/Http/Resources/cacert.pem > should use /etc/pki/tls/cert.pem > (ca-certificates on fedora, need to check on RHEL) > See https://fedoraproject.org/wiki/Features/SharedSystemCertificates > > In source code Guzzle/Http/Client.php > $opts[CURLOPT_CAINFO] = __DIR__ . '/Resources/cacert.pem' > This will obviously not work, with current version > (should use data_dir). > > (this is not a library, but for security reason, using > a bundled copy seems a very bad idea) Removed bundled cert > SHOULD: > > [!]: Latest version is packaged. > 3.1.2 is released Updated to 3.1.2 > [!]: %check is present and all tests pass. > as tests exists in upstream github, please > ask upstream to include them in the tarball Will work with upstream to get tests included in PEAR package. Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-guzzle-Guzzle.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-guzzle-Guzzle-3.1.2-1.fc18.src.rpm [x]: Package contains no bundled libraries. => fixed [x]: Latest version is packaged. => fixed No blocker. === APPROVED === THANKS for the review! New Package SCM Request ======================= Package Name: php-guzzle-Guzzle Short Description: PHP HTTP client library and framework for building RESTful web service clients Owners: siwinski Branches: f18 el6 InitialCC: Git done (by process-git-requests). php-guzzle-Guzzle-3.1.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-guzzle-Guzzle-3.1.2-1.el6 php-guzzle-Guzzle-3.1.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-guzzle-Guzzle-3.1.2-1.fc18 php-guzzle-Guzzle-3.1.2-1.fc18 has been pushed to the Fedora 18 testing repository. php-guzzle-Guzzle-3.2.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-guzzle-Guzzle-3.2.0-1.fc18 php-guzzle-Guzzle-3.2.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-guzzle-Guzzle-3.2.0-1.el6 php-guzzle-Guzzle-3.2.0-1.fc18 has been pushed to the Fedora 18 stable repository. php-guzzle-Guzzle-3.2.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |