Bug 885500
| Summary: | tuned ConfigParser use is broken when key contains ":" | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabrice Bellet <fabrice> | ||||||
| Component: | tuned | Assignee: | Jaroslav Škarvada <jskarvad> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 18 | CC: | jkaluza, jskarvad, jvcelak, pknirsch, twoerner | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-02-14 10:10:46 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 660676 [details]
Another fix
Thanks for spotting this.
Added alternate patch, that doesn't require python-configobj dep.
I took your patch, thanks. We will use the configobj parser to extend/clean the code for e.g. type verification. Upstream commit: https://fedorahosted.org/tuned/changeset/677458c174194a777aaed089ac084f826c47d1a7 This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This should be fixed in tuned-2.1.2, the current version in f18 is tuned-2.2.0-1.fc18. Thus I think this is already fixed. If the problem persists feel free to reopen. |
Created attachment 660439 [details] use configobj to parse config file recent tuned profiles have a [sysfs] section, where key,value couples are wrongly parsed by ConfigParser. This module allows both '=' and ':' to be a valid separator, which causes problems with entries like this one: #Runtime PM for PCI Device NEC Corporation uPD720200 USB 3.0 Host Controller /sys/bus/pci/devices/0000:0e:00.0/power/control=auto key=/sys/bus/pci/devices/0000 and value=0e:00.0/power/control=auto A possible solution is to switch to configobj instead, which works as expected, with minimal modifications to the code.