Bug 885739

Summary:

RedHat init script doesn't support overwriting of options from sysconfig

Product:

[Community] GlusterFS

Reporter:

Filip Pytloun <filip.pytloun>

Component:

scripts

Assignee:

Filip Pytloun <filip.pytloun>

Status:

CLOSED CURRENTRELEASE

QA Contact:

Severity:

medium

Docs Contact:

Priority:

medium

Version:

mainline

CC:

filip.pytloun, gluster-bugs, ndevos

Target Milestone:

---

Target Release:

---

Hardware:

Unspecified

OS:

Linux

Whiteboard:

Fixed In Version:

glusterfs-3.4.0

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2013-07-24 17:13:19 UTC

Type:

Bug

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
Patch	none

Description Filip Pytloun 2012-12-10 14:04:48 UTC

Description of problem:
RedHat init script doesn't support overwriting of daemon options from sysconfig - for eg. changing location of log file or log level.

Version-Release number of selected component (if applicable):


How reproducible:
Try to change glusterd log file or log level without editing init script

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Patch attached

Comment 1 Filip Pytloun 2012-12-10 14:05:30 UTC

Created attachment 660886 [details]
Patch

Comment 2 Amar Tumballi 2012-12-11 06:00:25 UTC

Hi Filip, thanks for the patch, can you please submit this upstream? (ref: http://www.gluster.org/community/documentation/index.php/Development_Work_Flow)

Comment 3 Niels de Vos 2012-12-11 08:59:04 UTC

Filip, I like this a lot but would like to see the following additions:
- an example /etc/sysconfig/glusterd file with comments and commented out options
- include /etc/sysconfig/glusterd in the glusterfs.spec.in as %config

Let me know if you need assistance in posting the patch in Gerrit for review, or if you want me to post the patch in your name.

Thanks,
Niels

Comment 4 Filip Pytloun 2012-12-11 09:50:30 UTC

Hello, thank you,
I have added example sysconfig file and opened Gerrit review: http://review.gluster.org/4290

Comment 5 Vijay Bellur 2012-12-12 15:36:39 UTC

CHANGE: http://review.gluster.org/4290 (RHEL init script: ability to overwrite options from sysconfig) merged in master by Anand Avati (avati)