Bug 886261
Summary: | Review Request: php-when - Date/Calendar recursion library for PHP 5.2+ | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gregor Tätzner <gregor> | ||||||||
Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | rawhide | CC: | fedora, kevin, notting, package-review, shawn | ||||||||
Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2013-01-20 03:10:10 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 858841 | ||||||||||
Attachments: |
|
Description
Gregor Tätzner
2012-12-11 22:01:49 UTC
As the Test suite is provided, you should run it during %check. For now, test suite isn't compatible with latest PHPUnit (use some deprecated include). so, for example, in %prep, remove this include, and fix the other include path sed -e '/Framework.php/d' \ -e '/When.php/s:./:when/:' \ -e '/When_Iterator.php/s:./:when/:' \ -i Tests/*php and in %check cd Tests phpunit -d include_path=%{buildroot}%{_datadir}/php:.:%{_datadir}/php:%{_datadir}/pear . Please don't install tests in /usr/share/php, which is part of the default include_path. Better solution is to use /usr/share/tests/when You need to own the /usr/share/tests directory (or require pear which own it) Please consider removing "5.2+" from summary, PHP is enough. Created attachment 663920 [details]
test execution
Does the test work for you? There are a lot of errors and some failures.
Try adding "-d date.timezone=UTC" to phpunit command Yes test works for me (local build). Of course, you probably need more BR to enable it during mock/koji build. Spec URL: http://brummbq.fedorapeople.org/php-when.spec SRPM URL: http://brummbq.fedorapeople.org/php-when-0.3-2.fc17.src.rpm (In reply to comment #3) > Try adding "-d date.timezone=UTC" to phpunit command > > Yes test works for me (local build). > Of course, you probably need more BR to enable it during mock/koji build. thanks, that did the trick. It works also in mock (In reply to comment #1) > Better solution is to use /usr/share/tests/when check > You need to own the /usr/share/tests directory (or require pear which own it) yum whatprovides /usr/share/tests php-Pimple-1.0.0-2.fc17.noarch : A simple Dependency Injection Container for PHP php-lessphp-0.3.8-3.fc17.noarch : A compiler for LESS written in PHP no sign of pear? However, I'm owning /usr/share/tests now as well. Created attachment 663994 [details]
phpci.log
Created attachment 663995 [details]
php-when-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 886261
See the few comments in the attached review report. No Blocker, so === APPROVED === New Package SCM Request ======================= Package Name: php-when Short Description: Date/Calendar recursion library for PHP Owners: brummbq Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). For the tests, wouldn't it be better to use "%{_datadir}/tests/%{name}" so it would be less likely for a directory name collision? php-when-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-when-0.3-2.fc17 php-when-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-when-0.3-2.fc18 php-when-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-when-0.3-2.el6 php-when-0.3-2.fc17 has been pushed to the Fedora 17 testing repository. php-when-0.3-2.fc18 has been pushed to the Fedora 18 stable repository. php-when-0.3-2.fc17 has been pushed to the Fedora 17 stable repository. php-when-0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |