Bug 886794

Summary:	REST-API : list files issues
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Oded Ramraz <oramraz>
Component:	ovirt-engine-restapi	Assignee:	Ravi Nori <rnori>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilia Meerovich <iliam>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.1.0	CC:	bazulay, dyasny, ecohen, iheim, mpastern, oramraz, pstehlik, Rhev-m-bugs, sgrinber, ykaul, yzaslavs
Target Milestone:	---
Target Release:	3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:	sf4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	915537

Description Oded Ramraz 2012-12-13 08:12:42 UTC

Description of problem:

I encountered few issues while using list files command 

1.list files --max parameter retrieve extra results ( see additional information )
2.not sure why id and name are equal for all entities . I think that it would be better if ID will be UUID or integer . 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

[RHEVM shell (connected)]# list files --storagedomain-identifier 7233a711-98e8-4c3c-bcfa-44c4bcc4f6c6 --max 3

id         : Windows2003-r2-x64-disc1.iso
name       : Windows2003-r2-x64-disc1.iso

id         : RHEL5.5-Server-20100201.0-x86_64-DVD.iso
name       : RHEL5.5-Server-20100201.0-x86_64-DVD.iso

id         : RHEV-toolsSetup_2.2_47513.iso
name       : RHEV-toolsSetup_2.2_47513.iso

id         : win2k3-32-with-virtio.vfd
name       : win2k3-32-with-virtio.vfd

id         : win2k8-32_with_virtio.vfd
name       : win2k8-32_with_virtio.vfd

id         : win7-32_with_virtio.vfd
name       : win7-32_with_virtio.vfd

[RHEVM shell (connected)]# list files --storagedomain-identifier 7233a711-98e8-4c3c-bcfa-44c4bcc4f6c6 --max 2

id         : fakeISO01.iso
name       : fakeISO01.iso

id         : RHEV-toolsSetup_2.3_327.iso
name       : RHEV-toolsSetup_2.3_327.iso

id         : win2k3-32-with-virtio.vfd
name       : win2k3-32-with-virtio.vfd

id         : win2k8-32_with_virtio.vfd
name       : win2k8-32_with_virtio.vfd

Comment 1 Michael Pasternak 2012-12-13 08:41:46 UTC

(In reply to comment #0)
> Description of problem:
> 
> I encountered few issues while using list files command 
> 
> 1.list files --max parameter retrieve extra results ( see additional
> information )
> 2.not sure why id and name are equal for all entities . I think that it
> would be better if ID will be UUID or integer . 
> 

none of the mentioned above is related to cli,

1. --max can be an issue in api on this sub-collection (will be checked)
2. works fine with RESTful api where ID is opaque (but you can file RFE against 
   api making it UUID).

Comment 2 Ravi Nori 2012-12-13 12:57:28 UTC

I am unable to reproduce the bug. Please try with the lastest cli code base and let me know if you can reproduce the bug.

Comment 3 Oded Ramraz 2012-12-13 13:03:02 UTC

Do you have both ISO's and VFD's in your ISO domain ? 
It seems like it retrieve X VFD's and X ISO's when using max query 

(In reply to comment #2)
> I am unable to reproduce the bug. Please try with the lastest cli code base
> and let me know if you can reproduce the bug.

Comment 4 Ravi Nori 2012-12-13 14:02:23 UTC

Yes I see the bug, this patch should fix the issue

http://gerrit.ovirt.org/#/c/10029/

change id : I7cf453d430f44dff8725ea11ecc0fa91d99844bc

Comment 5 Yair Zaslavsky 2013-01-08 15:12:04 UTC

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=af2824cc891026d2f405c2904995c81361084d31

Comment 6 Oded Ramraz 2013-02-06 10:03:45 UTC

[RHEVM shell (connected)]# list files --storagedomain-identifier 7233a711-98e8-4c3c-bcfa-44c4bcc4f6c6 --max 3

id         : RHEV-toolsSetup_2.3_395.iso
name       : RHEV-toolsSetup_2.3_395.iso

id         : MUI_Windows_server_2003_r2_cd1.iso
name       : MUI_Windows_server_2003_r2_cd1.iso

id         : RHEV-toolsSetup_2.3_338.iso
name       : RHEV-toolsSetup_2.3_338.iso


Verified sf5

Comment 7 Itamar Heim 2013-06-11 08:20:54 UTC

3.2 has been released

Comment 8 Itamar Heim 2013-06-11 08:24:05 UTC

3.2 has been released