Bug 887098
| Summary: | gluster mount crashes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | rhbugs | ||||
| Component: | access-control | Assignee: | vpshastry <vshastry> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 3.2.5 | CC: | gluster-bugs, nsathyan, rwheeler | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | glusterfs-3.5.0 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 902208 (view as bug list) | Environment: | |||||
| Last Closed: | 2014-04-17 11:39:48 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 902208 | ||||||
| Attachments: |
|
||||||
|
Description
rhbugs
2012-12-14 02:55:36 UTC
just one question, can you see for the testing sake, if 3.4.0qa5 fixes the problem for you? Another update, if the volume is not mounted with acl then the problem does not occur. Amar, I am attempting to try 3.4.0qa5. Will let you know how it goes. Confirmed it occurs with 3.4.0qa5 also. mount with -oacl, and happens everytime with the steps provided in bug description.
below patch fixes it.
-------------------
diff --git a/xlators/system/posix-acl/src/posix-acl.c b/xlators/system/posix-acl/src/posix-acl.c
index 3928a56..a3570c0 100644
--- a/xlators/system/posix-acl/src/posix-acl.c
+++ b/xlators/system/posix-acl/src/posix-acl.c
@@ -516,7 +516,7 @@ posix_acl_inherit_mode (struct posix_acl *acl, mode_t modein)
if (mask_ce) {
mask_ce->perm &= (mode >> 3) | ~S_IRWXO;
mode &= (mask_ce->perm << 3) | ~S_IRWXG;
- } else {
+ } else if (group_ce) {
group_ce->perm &= (mode >> 3) | ~S_IRWXO;
mode &= (group_ce->perm << 3) | ~S_IRWXG;
}
-----------------
Varun, please submit this patch with proper regression test script to review.
CHANGE: http://review.gluster.org/4351 (system/posix-acl: prevent NULL pointer dereference of group_ce) merged in master by Vijay Bellur (vbellur) Can this be backported to 3.3 ? CHANGE: http://review.gluster.org/4395 (system/posix-acl: prevent NULL pointer dereference of group_ce) merged in release-3.3 by Anand Avati (avati) REVIEW: http://review.gluster.org/5631 (tests: make sure to avoid 'grep' in ps output) posted (#1) for review on master by Harshavardhana (harsha) COMMIT: http://review.gluster.org/5631 committed in master by Vijay Bellur (vbellur) ------ commit 764c42813df3de9659a1ab7b7356779d2e5d64e5 Author: Harshavardhana <harsha> Date: Wed Aug 14 15:44:33 2013 -0700 tests: make sure to avoid 'grep' in ps output Change-Id: I48909facd2e3a2dc52a18e44d58c0e0fa2d96ec3 BUG: 887098 Signed-off-by: Harshavardhana <harsha> Reviewed-on: http://review.gluster.org/5631 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/5672 (tests: Avoid another 'grep' in ps output) posted (#1) for review on master by Harshavardhana (harsha) COMMIT: http://review.gluster.org/5672 committed in master by Vijay Bellur (vbellur) ------ commit cc8b149f34b3dc76a4ec094b822816852f6cfd5f Author: Harshavardhana <harsha> Date: Tue Aug 20 18:25:09 2013 -0700 tests: Avoid another 'grep' in ps output Previous fix at -----------------------------> 764c42813df3de9659a1ab7b7356779d2e5d64e5 <----------------------------- Was incomplete Change-Id: I6662168a7af078935a5cbcfae76ec40fc0c112b8 BUG: 887098 Signed-off-by: Harshavardhana <harsha> Reviewed-on: http://review.gluster.org/5672 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6671 (tests: fix bug-887098-gmount-crash.t check for mount liveness) posted (#1) for review on master by Krishnan Parthasarathi (kparthas) REVIEW: http://review.gluster.org/6671 (tests: fix bug-887098-gmount-crash.t check for mount liveness) posted (#2) for review on master by Krishnan Parthasarathi (kparthas) This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report. glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |