Bug 887436 (Horde_Crypt_Blowfish)

Summary:

Review Request: php-horde-Horde-Crypt-Blowfish - Blowfish Encryption Library

Product:

[Fedora] Fedora

Reporter:

Remi Collet <fedora>

Component:

Package Review

Assignee:

Shawn Iwinski <shawn>

Status:

CLOSED RAWHIDE

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

CC:

nb, notting, package-review, shawn

Target Milestone:

---

Flags:

shawn: fedora-review+
gwync: fedora-cvs+

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2012-12-20 13:51:42 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

874172

Attachments:

Description	Flags
phpci.log	none
php-horde-Horde-Crypt-Blowfish-review.txt	none

Description Remi Collet 2012-12-15 06:47:24 UTC

Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Crypt-Blowfish/php-horde-Horde-Crypt-Blowfish.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Crypt-Blowfish-1.0.1-1.remi.src.rpm
Description: 
Provides blowfish encryption/decryption for PHP string data.

Fedora Account System Username: remi

Comment 1 Remi Collet 2012-12-15 06:50:41 UTC

This is a fork of php-pear-Crypt-Blowfish 1.0.0, integrated with horde framework.
Horde have never support version 1.1.0.

Comment 2 Shawn Iwinski 2012-12-16 18:56:25 UTC

Created attachment 664461 [details]
phpci.log

Comment 3 Shawn Iwinski 2012-12-16 18:58:01 UTC

Created attachment 664462 [details]
php-horde-Horde-Crypt-Blowfish-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 887436 --mock-config fedora-rawhide-x86_64

Comment 4 Shawn Iwinski 2012-12-16 19:02:36 UTC

===== SHOULD items =====
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

Includes ORIGINAL_LICENSE which is BSD license, but does not contain a license file for LGPLv2.  Please request upstream to include one and add a comment to the spec.



No blockers.



===== APPROVED =====

Comment 5 Shawn Iwinski 2012-12-16 19:13:38 UTC

(In reply to comment #4)
> ===== SHOULD items =====
> [!]: If the source package does not include license text(s) as a separate
> file
>      from upstream, the packager SHOULD query upstream to include it.
> 
> Includes ORIGINAL_LICENSE which is BSD license, but does not contain a
> license file for LGPLv2.  Please request upstream to include one and add a
> comment to the spec.

Never mind this comment.  I was looking for a license file labeled LICENSE, but the license text is included in the COPYING file.

Comment 6 Remi Collet 2012-12-16 19:17:05 UTC

Thanks for the review


New Package SCM Request
=======================
Package Name: php-horde-Horde-Crypt-Blowfish
Short Description: Blowfish Encryption Library
Owners: remi
Branches: f18 el6
InitialCC:

Comment 7 Gwyn Ciesla 2012-12-16 23:59:12 UTC

Git done (by process-git-requests).