Bug 887818
| Summary: | a comprehensive /etc/swift/*.conf files should be included | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Nikola Dipanov <ndipanov> | ||||||
| Component: | openstack-swift | Assignee: | Pete Zaitcev <zaitcev> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Dafna Ron <dron> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 1.0 (Essex) | CC: | abaron, apevec, dron, dyocum, eglynn, fpercoco, hateya, lhh, mlopes, ndipanov, sclewis | ||||||
| Target Milestone: | beta | Keywords: | Triaged | ||||||
| Target Release: | 4.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | openstack-swift-1.8.0-7.el6ost | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | 887334 | Environment: | |||||||
| Last Closed: | 2013-12-19 23:53:30 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Nikola Dipanov
2012-12-17 12:05:06 UTC
Swift is of course special and its sample configs are not that useful as in other projects which use cfg and have autogenerated conf samples with doc comments: https://github.com/openstack/swift/tree/master/etc So this will require some upstream work, ideally to convert Swift to use oslo-cfg, and minimally to add doc comments in sample configs manually. Created attachment 757780 [details]
Proposed fix
I find the complete configs for Swift rather unweildy and difficult to
edit, although they would not be without precendent. Look at sample
configs for things like Postfix and Apache.
Still, I question my own ability to maintain them in 100% coherence
with the reality. I barely have cycles to audit changes to upstream
configs that we repackage as foo-sample.
Nicola, do you think you could be satisfied with better redirection
to comprehensive sample configs that we already install? Please see
the attached patch.
Created attachment 765343 [details]
Proposed fix
Comment on attachment 765343 [details] Proposed fix Looks good enough, it synces what upstream currently has in etc/*-sample but ideally upstream could improve the samples and add more documentation comments. Even more ideally, upstream would switch to oslo.config and generate samples from the code, like Nova does https://github.com/openstack/nova/tree/master/tools/conf conf files (although not hight detailed) exists: [root@nott-vdsa swift(keystone_admin)]# ls -l total 2456 -rw-r--r--. 1 root swift 787324 Sep 27 19:02 account.builder -rw-r--r--. 1 root swift 37564 Sep 27 19:02 account.ring.gz drwxr-sr-x. 2 root swift 4096 Sep 27 19:02 backups -rw-r--r--. 1 root swift 787326 Sep 27 19:02 container.builder -rw-r--r--. 1 root swift 37730 Sep 27 19:02 container.ring.gz -rw-r--r--. 1 root swift 787326 Sep 27 19:02 object.builder -rw-rw----. 1 root swift 291 Jun 20 13:24 object-expirer.conf -rw-r--r--. 1 root swift 37588 Sep 27 19:02 object.ring.gz drwxr-xr-x. 2 root root 4096 Jun 20 13:26 proxy-server -rw-rw----. 1 swift swift 1108 Sep 25 17:47 proxy-server.conf -rw-rw----. 1 swift swift 58 Sep 25 17:46 swift.conf verified for openstack-swift-1.8.0-6.el6ost.noarch Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2013-1859.html |