Bug 888253

Please use the following update submission link to create the Bodhi
request for this issue as it contains the top-level parent bug(s) as well
as this tracking bug.  This will ensure that all associated bugs get
updated when new packages are pushed to stable.

Please also ensure that the "Close bugs when update is stable" option
remains checked.

Bodhi update submission link:
https://admin.fedoraproject.org/updates/new/?type_=security&bugs=888249,888253

I can't build 0.48.4 on EL-5 it needs a newer intltool, is the inkscape 0.46 there affected?

(In reply to comment #2)

Hi Jon,

> I can't build 0.48.4 on EL-5 it needs a newer intltool, is the inkscape 0.46
> there affected?

Yes, it is. I have tried the reproducer from https://bugzilla.redhat.com/show_bug.cgi?id=888249#c1 yesterday and it works on EPEL-5 version too.

So we will need some other way how to fix this (backport the isolated patch).

Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Response Team

I understand what the patch is trying to accomplish, I'm just not sure how to get the allow_net_access option, Inkscape::Preferences *prefs = Inkscape::Preferences::get(); doesn't seem to work in 0.46.

(In reply to comment #4)
> I understand what the patch is trying to accomplish, I'm just not sure how
> to get the allow_net_access option, Inkscape::Preferences *prefs =
> Inkscape::Preferences::get(); doesn't seem to work in 0.46.

So what do you propose? Discontinue support for inkscape in EPEL-5 and delete it? (not that this flaw would be so critical, it would need to be done. But current limitation not being to able to build new updates might be a problem if / once there is a more urgent inkscape issue found).

No, possibly just simplify the patch to avoid the option check, and just disable network importing at those locations.  Thoughts?

(In reply to comment #6)
> No, possibly just simplify the patch to avoid the option check, and just
> disable network importing at those locations.  Thoughts?

So divided into coins, what you suggest wrt to:
  http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/11931

is that the patch would use just:

  1115 int parse_options = XML_PARSE_RECOVER + XML_PARSE_NOWARNING + XML_PARSE_NOERROR;  // do not use XML_PARSE_NOENT ! see bug lp:1025185

at src/ui/dialog/ocaldialogs.cpp and use just:

  300 int parse_options = XML_PARSE_HUGE; // do not use XML_PARSE_NOENT ! see bug lp:1025185
  
  and

-  305               XML_PARSE_NOENT | XML_PARSE_HUGE);
+  311               parse_options);

at src/xml/repr-io.cpp, right? (IOW explicitly disable the XML_PARSE_NOENT by default without ability to switch it on again [without custom recompilation], right?)

Pretty much.  Will that suffice to fix the flaw?

(In reply to comment #8)
> Pretty much.  Will that suffice to fix the flaw?

Yes, that should fix the problem.

Got it, patched, confirmed fixed, building.

(In reply to comment #10)
> Got it, patched, confirmed fixed, building.

Ok, brilliant. Thanks.

inkscape-0.46-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/inkscape-0.46-3.el5

Package inkscape-0.46-3.el5:
* should fix your issue,
* was pushed to the Fedora EPEL 5 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing inkscape-0.46-3.el5'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-13822/inkscape-0.46-3.el5
then log in and leave karma (feedback).

inkscape-0.46-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.