Bug 889088

Summary:	Prompt error message when restore the app
Product:	OpenShift Container Platform	Reporter:	xjia <xjia>
Component:	oc	Assignee:	Brenton Leanhardt <bleanhar>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	1.2.0	CC:	bleanhar, libra-onpremise-devel, mmasters, xtian
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-31 20:33:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description xjia 2012-12-20 08:04:21 UTC

Description of problem:
Firstly, save one app, then restore it, it fails. It prompts error message :

[root@broker ~]# rhc snapshot restore perl -pjia 
/usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/commands/snapshot.rb:66:in `restore': uninitialized constant RHC::TarGz (NameError)
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/commands.rb:137:in `send'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/commands.rb:137:in `to_commander'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/command.rb:180:in `call'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/command.rb:180:in `call'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/command.rb:155:in `run'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/runner.rb:385:in `run_active_command'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/command_runner.rb:61:in `run!'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/delegates.rb:7:in `run!'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/cli.rb:41:in `start'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/bin/rhc:18
	from /usr/bin/rhc:19:in `load'
	from /usr/bin/rhc:19

Version-Release number of selected component (if applicable):
OpenShiftEnterprise/1.1.x/2012-12-19.2/
rhc 1.3.2

How reproducible:
always

Steps to Reproduce:
1. Create app
2. Snapshot save the app
3. Modify something in app's git repo, then git push
4. Restore the app

Actual results:
[root@broker ~]# rhc snapshot restore perl -pjia 
/usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/commands/snapshot.rb:66:in `restore': uninitialized constant RHC::TarGz (NameError)
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/commands.rb:137:in `send'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/commands.rb:137:in `to_commander'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/command.rb:180:in `call'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/command.rb:180:in `call'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/command.rb:155:in `run'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/runner.rb:385:in `run_active_command'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/command_runner.rb:61:in `run!'
	from /usr/lib/ruby/gems/1.8/gems/commander-4.0.3/lib/commander/delegates.rb:7:in `run!'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/lib/rhc/cli.rb:41:in `start'
	from /usr/lib/ruby/gems/1.8/gems/rhc-1.3.2/bin/rhc:18
	from /usr/bin/rhc:19:in `load'
	from /usr/bin/rhc:19

Expected results:
Restore it sucessfully.

Additional info:

Comment 2 Miciah Dashiel Butler Masters 2012-12-20 15:29:48 UTC

Here's the fix upstream: https://github.com/openshift/rhc/commit/524e980957528aa9e9582d3439f80368f751ffc1

Comment 3 Brenton Leanhardt 2012-12-20 16:12:36 UTC

Great.  It's looking like there will be a number of upstream fixes today.  I'm going to merge in the latest in a few hours and then rebuild the puddle.

Comment 4 Brenton Leanhardt 2013-01-07 22:18:17 UTC

This will ship with the next puddle.

Comment 5 xjia 2013-01-08 03:11:34 UTC

[root@client ~]# rhc snapshot save php -pjia
Pulling down a snapshot to php.tar.gz...
Running extra dump for mysql-5.1
MySQL already running
 72.8%
Waiting for stop to finish
Done
Creating and sending tar.gz
Running extra cleanup for mysql-5.1
Done

RESULT:
Success
[root@client ~]# rhc snapshot restore php -pjia
Restoring from snapshot php.tar.gz...
Removing old git repo: ~/git/php.git/
Removing old data dir: ~/app-root/data/*
Restoring ~/git/php.git and ~/app-root/data
Running extra restore for mysql-5.1
MySQL already running
restart_on_add=false
Executing Jenkins build.

You can track your build at https://jenkins-jia.example.com/job/php-build

Waiting for build to schedule....Done
Waiting for job to complete...............Done
SUCCESS
New build has been deployed.

RESULT:
Success
[root@client ~]# 



Version:
http://buildvm-devops.usersys.redhat.com/puddle/build/OpenShiftEnterprise/1.1.x/2013-01-07.2/

Comment 7 errata-xmlrpc 2013-01-31 20:33:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0220.html