Bug 889317
Summary: | spacewalk-clone-by-date crashes instead of printing a usage error message when usage is incorrect | ||
---|---|---|---|
Product: | [Community] Spacewalk | Reporter: | Stephen Herr <sherr> |
Component: | Clients | Assignee: | Stephen Herr <sherr> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Satellite QA List <satqe-list> |
Severity: | low | Docs Contact: | |
Priority: | medium | ||
Version: | 1.9 | CC: | cperry, dyordano, ksugawar |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 810090 | Environment: | |
Last Closed: | 2013-03-06 18:34:22 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 810090 | ||
Bug Blocks: | 917805 |
Description
Stephen Herr
2012-12-20 19:23:41 UTC
Committed to Spacewalk master: 4d31003ed6ed328412d0ef28b989de182cc36c99 Sadly this will not work for us, because argparse wasn't introduced until python 2.7 and we have to support python 2.4 and 2.6. :( It looks like the hacky solution is the only one available to us. Reverting the commit in comment 1 and committing the new fix to Spacewalk master: d5742d1c807f3fd001f05d5b8db940ce700a8298 And ae72e3433fab82459b98cb09290545a765abd3a3 and 1d9b7146214e663c77b4209fa1cf8df97d871ce0 The username check needs to happen after we verify the channel args. I have also added a similar check for the --parents args. and 4c21c742bb41d326284118fc0532fb330a24b04a Adding more thorough checking so we can detect all instances where the user does specify two args for either --channels or --parents. and c1e54e3ea1d085e1a1626dc978af8b2b27731cee Removing redundant (and potentially incorrect) check Marking bug as ON_QA since tonight's build of Spacewalk nightly is a release candidate for Spacewalk 1.9. Spacewalk 1.9 has been released. https://fedorahosted.org/spacewalk/wiki/ReleaseNotes19 |