Bug 889630
Summary: | gluster volume delete is not atomic | |||
---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | David Bronaugh <dbronaugh> | |
Component: | glusterd | Assignee: | Krutika Dhananjay <kdhananj> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
Severity: | high | Docs Contact: | ||
Priority: | high | |||
Version: | 3.3.0 | CC: | amarts, gluster-bugs, scotty | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | glusterfs-3.4.0 | Doc Type: | Bug Fix | |
Doc Text: |
Cause:
glusterd does not fully clean up the volume store if there are non-empty directories present, during 'volume delete'.
Consequence:
a. Volume delete fails on the node where volume store cleanup fails.
b. Subsequent attempts to restart glusterd fail.
Fix:
Rename the volume directory path to a new location
<working-dir>/trash/<volume-id>.deleted, and then go on to clean up its contents. The volume is considered deleted once rename() succeeds, irrespective of whether the cleanup succeeds or not.
Result:
With this change, the problem is fixed IF moving the volume directory to "trash" is successful.
|
Story Points: | --- | |
Clone Of: | ||||
: | 902215 (view as bug list) | Environment: | ||
Last Closed: | 2013-07-24 17:45:12 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 902215 |
Description
David Bronaugh
2012-12-22 00:36:30 UTC
David, thanks for the report, and we too think this has to be fixed soon. Meantime, can you see the behavior in 3.4.0qa (qa6 is latest at the moment) releases? KP, any idea if this is already fixed in master branch? Hi David, Could you please find out if it was "swift.pid" that you said you found in /var/lib/glusterd/vols/skateboard0/run/ ? Thanks. CHANGE: http://review.gluster.org/4639 (glusterd: Mark vol as deleted by renaming voldir before cleaning up the store) merged in master by Anand Avati (avati) |