Bug 891230

Summary: nodejs-retry - Retry strategies for failed operations
Product: [Fedora] Fedora Reporter: T.C. Hollingsworth <tchollingsworth>
Component: Package ReviewAssignee: Miro Hrončok <mhroncok>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mhroncok, misc, notting, package-review
Target Milestone: ---Flags: mhroncok: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-13 12:06:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 891171, 891215    

Description T.C. Hollingsworth 2013-01-02 09:18:19 UTC
Spec: http://patches.fedorapeople.org/npm/nodejs-retry.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-retry-0.6.0-1.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4831099
FAS username: patches

Abstraction for exponential and custom retry strategies for failed operations.

This package is part of the npm stack and a future F19 Feature for Node.js.

This package may depend on other packages in the npm stack that aren't explicitly
listed as dependencies of this bug.  For more information, see bug 891171.

Please use nodejs-0.6.5-3 or later when building or using this package.

Comment 1 Michael S. 2013-01-08 22:09:52 UTC
Seems the license is missing :
License:        FIXME

It seems to be MIT, if I am not wrong.

Comment 2 T.C. Hollingsworth 2013-01-10 07:53:00 UTC
Sorry about that, the license is fixed now.  This version is also updated with empty %build sections and other issues found in various reviews.

Spec: http://patches.fedorapeople.org/npm/nodejs-retry.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-retry-0.6.0-2.fc17.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854384

Comment 3 Miro Hrončok 2013-01-11 18:11:56 UTC
Summary and Description OK.

MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.

$ rpmlint ../SRPMS/nodejs-retry-0.6.0-2.fc18.src.rpm ../RPMS/noarch/nodejs-retry-0.6.0-2.fc18.noarch.rpm
nodejs-retry.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

False positive.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.

License chcecked in License file: MIT. OK

MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git.

$ sha256sum ../SOURCES/retry-0.6.0.tgz 
983e676af24ff4dcbac396420fca3c195ce3b1de5f731f697888b4fe6b7bbd2a  ../SOURCES/retry-0.6.0.tgz
$ spectool -g nodejs-retry.spec 
Getting http://registry.npmjs.org/retry/-/retry-0.6.0.tgz to ./retry-0.6.0.tgz
$ sha256sum retry-0.6.0.tgz 
983e676af24ff4dcbac396420fca3c195ce3b1de5f731f697888b4fe6b7bbd2a  retry-0.6.0.tgz


MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK
MUST: Permissions on files must be set properly.

$ rpm -q -lv -p ../RPMS/noarch/nodejs-retry-0.6.0-2.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 11 19:05 /usr/lib/node_modules/retry
-rw-r--r--    1 root    root                       40 úno 14  2012 /usr/lib/node_modules/retry/index.js
drwxr-xr-x    2 root    root                        0 led 11 19:05 /usr/lib/node_modules/retry/lib
-rw-r--r--    1 root    root                     1102 úno 14  2012 /usr/lib/node_modules/retry/lib/retry.js
-rw-r--r--    1 root    root                     2267 úno 14  2012 /usr/lib/node_modules/retry/lib/retry_operation.js
drwxr-xr-x    2 root    root                        0 led 11 19:05 /usr/lib/node_modules/retry/node_modules
-rw-r--r--    1 root    root                      557 úno 14  2012 /usr/lib/node_modules/retry/package.json
drwxr-xr-x    2 root    root                        0 led 11 19:05 /usr/share/doc/nodejs-retry-0.6.0
-rw-r--r--    1 root    root                     1139 úno 14  2012 /usr/share/doc/nodejs-retry-0.6.0/License
-rw-r--r--    1 root    root                     5568 úno 14  2012 /usr/share/doc/nodejs-retry-0.6.0/Readme.md
-rw-r--r--    1 root    root                     1209 úno 14  2012 /usr/share/doc/nodejs-retry-0.6.0/equation.gif
drwxr-xr-x    2 root    root                        0 led 11 19:05 /usr/share/doc/nodejs-retry-0.6.0/example
-rw-r--r--    1 root    root                      685 úno 14  2012 /usr/share/doc/nodejs-retry-0.6.0/example/dns.js


MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK
MUST: Packages must not own files or directories already owned by other packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK

SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK

TODO: Please consider running tests when dependencies are ready for Fedora.

Resolution: APPROVED.

Comment 4 T.C. Hollingsworth 2013-01-11 20:51:57 UTC
New Package SCM Request
Package Name: nodejs-retry
Short Description: Retry strategies for failed operations
Owners: patches
Branches: f18 el6

Comment 5 Gwyn Ciesla 2013-01-13 00:58:41 UTC
Git done (by process-git-requests).

Comment 6 T.C. Hollingsworth 2013-01-13 12:06:32 UTC
BUilt for rawhide:

Comment 7 Fedora Update System 2013-04-05 23:16:46 UTC
node-gyp-0.9.1-2.fc18, nodejs-async-0.2.6-1.fc18, nodejs-chmodr-0.1.0-2.fc18, nodejs-fstream-npm-0.1.4-1.fc18, nodejs-glob-3.1.21-1.fc18, nodejs-minimatch-0.2.11-1.fc18, nodejs-mkdirp-0.3.5-1.fc18, nodejs-npm-registry-client-0.2.18-2.fc18, nodejs-read-package-json-0.2.2-1.fc18, nodejs-request-2.14.0-1.fc18, nodejs-semver-1.1.4-1.fc18, npm-1.2.14-2.fc18, nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18, nodejs-inherits-1.0.0-6.fc18, nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18, nodejs-retry-0.6.0-2.fc18, nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18, nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18, nodejs-init-package-json-0.0.7-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18, nodejs-proto-list-1.2.2-2.fc18, nodejs-which-1.0.5-4.fc18, nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18, nodejs-once-1.1.1-2.fc18, nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18, nodejs-block-stream-0.0.6-4.fc18, nodejs-npmlog-0.0.2-2.fc18, nodejs-opener-1.3.0-4.fc18, nodejs-tobi-cookie-0.3.2-2.fc18, nodejs-promzard-0.2.0-3.fc18, nodejs-combined-stream-0.0.4-1.fc18, nodejs-config-chain-1.1.5-1.fc18, nodejs-fstream-0.1.22-1.fc18, nodejs-fstream-ignore-0.0.6-1.fc18, nodejs-graceful-fs-1.2.0-1.fc18, nodejs-ini-1.1.0-1.fc18, nodejs-lockfile-0.3.0-1.fc18, nodejs-lru-cache-2.2.2-1.fc18, nodejs-mime-1.2.9-1.fc18, nodejs-nopt-2.1.1-1.fc18, nodejs-npmconf-0.0.23-1.fc18, nodejs-read-installed-0.1.1-1.fc18, nodejs-rimraf-2.1.4-1.fc18, nodejs-tar-0.1.16-1.fc18, nodejs-form-data-0.0.7-1.fc18 has been pushed to the Fedora 18 stable repository.