Bug 891751

Summary: Bugzilla does not handle commas/spaces gracefully when reading bug activity
Product: [Community] Bugzilla Reporter: Jan Pokorný [poki] <jpokorny>
Component: Email NotificationsAssignee: Simon Green <sgreen>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.4CC: ebaak, jmcdonal
Target Milestone: 4.4Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.4.0009 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-04 00:46:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
the original of Doc Text none

Description Jan Pokorný [poki] 2013-01-03 21:16:16 UTC 
Created attachment 672219 [details]
the original of Doc Text

I've just noticed I probably hit such corner case when I added Doc Text
for bug [886678].  In the text email, I can see (cropped):

> What    |Removed                     |Added                      
> -----------------------------------------------------------------
> Doc Text|                            |Cause:                     
>         |                            |Value for "Oracle          
>         |                            |Installation Type"         
>         |                            |parameter when listing     
>         |                            |details                    
>         |                            |for existing Oracle 10g/11G
>         |                            |Failover Instance resource 
>         |                            |did not                    
>         |                            |reflect the actual         
>         |                            |configured value           
> Doc Text|                            |"Default" was selected     
>         |                            |regardless.                
>         |                            |                           
>         |                            |Consequence:               
>         |                            |Any modification of such   
>         |                            |resource without explicitly
>         |                            |correcting                 
>         |                            |the value for "Oracle      
>         |                            |Installation Type" resulted
>         |                            |in unexpected              
>         |                            |propagation of "10g"       
>         |                            |(current default value) as 
>         |                            |a requested type           
>         |                            |of                         
> Doc Text|                            |database (from a few       
>         |                            |supported) into cluster    
>         |                            |configuration.             
>         |                            |                           
>         |                            |Fix:                       
>         |                            |Luci now correctly reflects
>         |                            |the actual configured value
>         |                            |for this                   
>         |                            |item.                      
>         |                            |                           
>         |                            |Result:                    
>         |                            |Such accidental change can 
>         |                            |no longer happen.          

However, the relevant part in original says:

> [...] the actual configured value, "Default" was selected regardless.
                                  ^^^
                                 comma

You can observe the same looking into the bug history [1].

I think there should be best effort to preserve the original, incl.
not stripping commas and other "underestimated" characters.

Or maybe I triggered off-by-one error in string handling?
As I am editing forms in an external editor, I am also attaching
the exact content (formatting, etc.) of the Doc Text I have sent.

Current bugzilla version as indicated at the homepage: 4.2.4-7


[1] https://bugzilla.redhat.com/show_activity.cgi?id=886678
Comment 1 Simon Green 2013-01-04 10:25:00 UTC 
f%#@ :-/
Comment 2 Simon Green 2013-01-05 10:17:58 UTC 
Ignore comment #1. What I thought was causing the problem, wasn't.

The bugs_activity table has a limit of 255 characters (thanks Oracle!) for the added and removed values. Therefore the Doc Text field does need to be split into multiple entries some times.

Bugzilla 4.4 will recreate the change into a single row. Based on this I'm marking the bug as CLOSED/UPSTREAM
Comment 3 Jan Pokorný [poki] 2013-08-23 12:37:32 UTC 
There still seems to be something wrong about the Doc Text and its
reified reprezentation -- now in the history changes in the comments
row.

See under [bug 888543 comment 10]:

> resources when being unloaded , preventing the crash on reload.
                               ^

Why is there the denoted space?
When I try to edit the field, I can see:

> resources when being unloaded,<new-line>preventing the crash on reload.
Comment 4 Jason McDonald 2013-08-29 03:42:49 UTC 
The issue mentioned in Comment #3 occured on 2013-08-22 and therefore does not appesr to be an artifact of the old Bugzilla 4.2 behaviour.
Comment 5 Simon Green 2013-09-16 01:20:35 UTC 
The following generic text will cause the issue (commas deliberately in the wrong place):

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo, consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

It happens when the string is greater than 255 characters and a comma occurs before this 255th character.
Comment 7 Simon Green 2013-10-04 00:46:35 UTC 
This change is now live. If there are any issues, do not reopen this bug.
Instead, you should create a new bug and reference this bug.

  -- simon