Bug 891868

Summary:	Review Request: perl-Unicode-Stringprep - Preparation of Internationalized Strings (RFC 3454)
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <mathieu>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-21 03:57:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	891873

Description Mathieu Bridon 2013-01-04 09:58:38 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Unicode-Stringprep.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Unicode-Stringprep-1.104-1.fc18.src.rpm

Description:
This module implements the stringprep framework for preparing Unicode
text strings in order to increase the likelihood that string input and
string comparison work in ways that make sense for typical users
throughout the world. The stringprep protocol is useful for protocol
identifier values, company and personal names, internationalized domain
names, and other text strings.

Fedora Account System Username: bochecha

Comment 1 Petr Šabata 2013-01-15 15:24:38 UTC

Taking the review.

Comment 2 Petr Šabata 2013-01-15 16:03:42 UTC

Issues:

You're missing some build dependencies, namely:
perl(Carp) from lib/Unicode/Stringprep.pm:16 and lib/Unicode/Stringprep/_Common.pm:9
perl(Exporter) from lib/Unicode/Stringprep.pm:12
perl(Unicode::Normalize) from lib/Unicode/Stringprep.pm:18 and t/99_perl-5.11.3.t:9

Your package provides modules from the eg directory, namely:
perl(Acme::Examples::Authen::SASL::SASLprep) = 1.00
perl(Acme::Examples::Net::IDN::Nameprep) = 1.00
Filter them out.

The README file is not in UTF-8; convert it.
It's most probably Latin1 (author's name on line 43).

Comment 3 Mathieu Bridon 2013-01-17 07:39:57 UTC

Thanks for the comments Petr, all the issues you raised should be fixed by this new package.

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Unicode-Stringprep.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Unicode-Stringprep-1.104-2.fc18.src.rpm

Comment 4 Petr Šabata 2013-01-17 15:41:14 UTC

All issues addressed, approving.

Comment 5 Mathieu Bridon 2013-01-18 03:09:03 UTC

New Package SCM Request
=======================
Package Name: perl-Unicode-Stringprep
Short Description: Preparation of Internationalized Strings (RFC 3454)
Owners: bochecha
Branches: devel
InitialCC: perl-sig

Comment 6 Gwyn Ciesla 2013-01-18 11:58:12 UTC

Git done (by process-git-requests).

Comment 7 Mathieu Bridon 2013-01-21 03:57:29 UTC

Thanks for the review Petr, and thank you Jon for the Git processing.

Package built in Rawhide, closing.