Bug 892597
Summary: | Review Request: glite-lb-types - Build-time component for gLite L&B | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | František Dvořák <valtri> |
Component: | Package Review | Assignee: | Petr Šabata <psabata> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, perl-devel, psabata |
Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | glite-lb-types-2.0.7-2.fc19 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-07-17 03:00:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
František Dvořák
2013-01-07 11:16:34 UTC
Spec URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-1/glite-lb-types.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-1/glite-lb-types-2.0.7-1.fc20.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5540505 New upstream version and packaging fixes. Taking the review. You'll need to buildrequire the following: - perl (called in spec) - perl(Getopt::Long), ./configure:26 - perl(POSIX), ./configure:27 Don't use absolute paths in your spec. Call perl simply 'perl' (preferred) or use the %{__perl} macro. Put the installled C header file in a devel subpackage, as mandated by the packaging guidelines. Since your Summary and %description are identical, consider using the %{summary} macro. The %check section doesn't run anything and can be dropped. Thanks for the review, I'll incorporate the changes. About the header file in separate subpackage: there is mentioned in Perl section the header files shouldn't be split off (but maybe this is a different case?): https://fedoraproject.org/wiki/Packaging:Perl#.h_files_in_module_packages You're right, keep that part as is :) Spec URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-2/glite-lb-types.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-2/glite-lb-types-2.0.7-2.fc20.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5551324 New packaging with the changes. Ok, looks good. Approving. New Package SCM Request ======================= Package Name: glite-lb-types Short Description: Build-time component for gLite L&B Owners: valtri Branches: f18 f19 el6 InitialCC: Git done (by process-git-requests). glite-lb-types-2.0.7-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.7-2.fc19 glite-lb-types-2.0.7-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.7-2.fc18 glite-lb-types-2.0.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.7-2.el6 glite-lb-types-2.0.7-2.fc19 has been pushed to the Fedora 19 testing repository. glite-lb-types-2.0.7-2.fc19 has been pushed to the Fedora 19 stable repository. glite-lb-types-2.0.7-2.fc18 has been pushed to the Fedora 18 stable repository. glite-lb-types-2.0.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository. glite-lb-types-2.0.10-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.10-3.el7 glite-lb-types-2.0.10-3.el7 has been pushed to the Fedora EPEL 7 stable repository. |