Bug 893078

Summary:	/distribution/install creates /etc/syslog.conf with incorrect SELinux label
Product:	[Retired] Beaker	Reporter:	Jan Hutař <jhutar>
Component:	tests	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.6	CC:	aigao, asaha, dcallagh, llim, qwan, rmancy, xjia
Target Milestone:	0.15.4
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	SELinux
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-17 22:38:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	545868

Description Jan Hutař 2013-01-08 14:26:07 UTC

Description of problem:
When I run restorecon on /etc, it founds /etc/syslog.conf have incorrect SELinux context. Also that better way for rsyslog would be to use /etc/rsyslog.d for such a cases.


Version-Release number of selected component (if applicable):
beaker-distribution-install-1.10-14.noarch
selinux-policy-targeted-3.10.0-96.fc16.noarch


How reproducible:
always


Steps to Reproduce:
1. restorecon -vR /etc/


Actual results:
# restorecon -vR /etc/
restorecon reset /etc/syslog.conf context unconfined_u:object_r:etc_t:s0->unconfined_u:object_r:syslog_conf_t:s0


Expected results:
No problem should be reported


Additional info:
http://git.fedorahosted.org/cgit/beaker.git/tree/Tasks/distribution/install/default/runtest.sh#n78

Comment 4 Dan Callaghan 2014-02-03 00:29:38 UTC

It looks like that syslog.conf stuff has no effect on RHEL6+ (which uses rsyslog instead), and it seems quite questionable. I doubt anything else is even still relying on that redirection of local2, seems like an RHTS-ism.

The task should just append to /etc/syslog.conf only if it already exists. That way the hack will continue to happen on RHEL5 and lower where it actually has some effect, but won't create spurious files for no reason on newer distros.

Comment 5 Dan Callaghan 2014-02-03 00:33:02 UTC

On Gerrit: http://gerrit.beaker-project.org/2755

Comment 8 Dan Callaghan 2014-02-17 22:38:56 UTC

distribution-install-1.12-1 has been released.