Bug 893298

Summary: Lack of a dot in domain create and update page
Product: OKD Reporter: Mengjiao Gao <mgao>
Component: WebsiteAssignee: Clayton Coleman <ccoleman>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 2.xCC: dmcphers, szhou, yujzhang
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 895355 (view as bug list) Environment:
Last Closed: 2013-02-14 00:39:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 895355    
Attachments:
Description Flags
Lack a dot in the front of the "rhcloud.com" in the domain update page. none

Description Mengjiao Gao 2013-01-09 04:21:59 UTC
Created attachment 675238 [details]
Lack a dot in the front of the "rhcloud.com" in the domain update page.

Description of problem:

When creating or updating domain name, lack of a dot after the input form of new domain name.

Version-Release number of selected component (if applicable):
devenv_2649, PROD

How reproducible:
always

Steps to Reproduce:
1.Create a domain name, using jia
2.Update domain name

Actual results:
In page /app/account/domain and page /app/account/domain/edit , the public url of the application shown as: http://applicationname–jia rhcloud.com
See the attached file

Expected results:
There should be a dot in the front of "rhcloud.com" ,like: http://applicationname–jia.rhcloud.com
Additional info:

Comment 1 Clayton Coleman 2013-01-10 20:18:50 UTC
Fixed in https://github.com/openshift/origin-server/pull/1139

Comment 2 Yujie Zhang 2013-01-11 05:43:37 UTC
(In reply to comment #1)
Tested on devenv_2662, the code is not merged, but it really worked if I made the following changes manually to ./opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-console-1.3.3/app/views/domains/_form.html.haml  on instance:

-        %span.add-on>= RestApi.application_domain_suffix
+        %span.add-on>= ".#{RestApi.application_domain_suffix}"

Will test it again when the code is in.

Comment 3 Yujie Zhang 2013-01-14 02:58:38 UTC
Tested on devenv_2669, the dot has been added on change domain page, verify this bug.

Comment 4 openshift-github-bot 2013-01-30 20:10:54 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/7d04af0491ec3ea030bd4ca0b25571fab50cf773
Bug 893298 - fixing the missing . on the site /account page