Bug 893997
| Summary: | add test for having debug output to syslog | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gene Czarcinski <gczarcinski> | ||||
| Component: | os-prober | Assignee: | Hedayat Vatankhah <hedayatv> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 18 | CC: | hedayatv | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-02-16 00:59:26 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
I'd personally prefer to have it on by default (or Anaconda developers must also explicitly enable it at the same time) if it is going to remain as a Fedora patch; so that it'll remain compatible with upstream. Also note that people will rarely need to run os-prober or grub2-mkconfig. But, I'll report this unmodified to upstream to see what they say in this regard. There are certain circumstances where grubby does not work: https://bugzilla.redhat.com/show_bug.cgi?id=864198 But my real question is why should debug output to syslog be enabled by default. The change to make this a runtime option is simple and easy to use. First, notice that it was my personal opinion. I've posted your comment and patch to upstream bug tracker without any changes. But, if it is going to be applied as a Fedora patch, I'll turn logging enabled by default, since: 1. it is compatible with upstream version, which is generally preferred, 2. os-prober/grub2-mkconfig are rarely run by most users, but one of the times which it is run is in anaconda, in which logging must be enabled. And if grubby doesn't work, it is its bug which should be fixed until it is the main way of updating grub.conf. About your question: I don't say that it should, and you can follow upstream bug and post comments if required. I say that I prefer upstream developers decide which is better, and I prefer to not apply patches when not really required and doesn't fix a real bug. It is also aligned with Fedora policy in general. BTW, I might apply your patch but with debugging enabled by default. And users who actually run os-prober/grub2-mkconfig regularly can disable it by declaring the variable in their environment (e.g. in bash_profile). I pretty much agree with everything you said and can work with either way of the default. os-prober-1.57-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/os-prober-1.57-1.fc17 os-prober-1.57-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/os-prober-1.57-1.fc18 Package os-prober-1.57-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing os-prober-1.57-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-1840/os-prober-1.57-1.fc17 then log in and leave karma (feedback). os-prober-1.57-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/os-prober-1.57-2.fc17 os-prober-1.57-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/os-prober-1.57-2.fc18 os-prober-1.57-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. os-prober-1.57-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 676312 [details] small patch to enable/disable debug output Description of problem: Currently, os-prober generates a great deal of debug messages to syslog. While these are certainly useful when debugging, they are just cluttering the syslog when not debugging. The attached patch requires that OS_PROBER_ENABLE_DEBUG be set to have the output. Version-Release number of selected component (if applicable): Fedora 18, os-prober-1.56-1