Bug 894119
Summary: | Review Request: vert.x - Framework for JavaScript, CoffeeScript, Ruby, Python, Groovy and Java | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matias Kreder <delete> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | cbredesen, lgao, msuchy, package-review, vondruch |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-07-21 13:50:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matias Kreder
2013-01-10 18:41:12 UTC
Just a few notes from me (not that I am taking the review) * Descriptive summary - Could you please provide better summary? Framework for some dynamic language list is not too helpful to know what is the package/framework good for. * No inclusion of pre-built binaries or libraries - It seems that you are shipping pre-build .jars. According to this guideline, you have to remove the original .jars and rebuild them from sources. Please note that I am not Java packaging expert, so I'll cannot help you with this further. * Split package into subpackages - It seems that there are shipped bindings for various other languages. I would suggest to split these into language specific subpackages. User could later choose just the subpackage (s)he needs and save some space. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries hi for hazelcast https://bugzilla.redhat.com/show_bug.cgi?id=972323 source code is available here ... https://github.com/eclipse/vert.x/ but seem use gradle for build ... but currently in f2x is broken https://bugzilla.redhat.com/show_bug.cgi?id=992428 regards It seems a long time this package review process does not go on, I fired a new bug: 1110070 for Vert.x version 2.1. Closing if favour of bug 1110070. Feel free to reopen if you still want to have v1 packaged. |