Bug 894428

Summary:	wrong filter for autofs maps in sss_cache
Product:	Red Hat Enterprise Linux 6	Reporter:	Jakub Hrozek <jhrozek>
Component:	sssd	Assignee:	Jakub Hrozek <jhrozek>
Status:	CLOSED ERRATA	QA Contact:	Kaushik Banerjee <kbanerje>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.4	CC:	dpal, grajaiya, jgalipea, okos, pbrezina, tlavigne
Target Milestone:	rc	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sssd-1.9.2-72.el6	Doc Type:	Bug Fix
Doc Text:	No documentation needed.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-21 09:43:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	902691

Description Jakub Hrozek 2013-01-11 17:42:51 UTC

This bug is created as a clone of upstream ticket:
https://fedorahosted.org/sssd/ticket/1754

In sss_cache.c:update_all_filters() we are passing a filter that requires three arguments in the update_filter() function for autofs.

But the upda_filter function only knows how to handle 2 arguments.

I suggest the update_filter() function is changed to not take a format at all, but only explicit parameters.

Comment 1 Jakub Hrozek 2013-01-14 08:15:00 UTC

Upstream has a devel-tested patch.

Comment 3 Jenny Severance 2013-01-14 19:14:28 UTC

Please add steps to reproduce and verify

Comment 4 Jakub Hrozek 2013-01-14 19:17:42 UTC

To reproduce, run
sss_cache -a auto.master

It won't work without the patch and chances are the tool will segfault.

if you also add --debug 10 you'll be able to see malformed filter without the patch and a correct one with the patch.

Comment 5 Jakub Hrozek 2013-01-15 19:39:26 UTC

Pushed upstream.

Comment 7 Kaushik Banerjee 2013-01-27 18:43:09 UTC

Verified in version 1.9.2-82

Output from beaker automation run:
:: [   PASS   ] :: Running 'sss_cache -A --domain=LDAP --debug 10 2> /tmp/cache_debugout'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'failed'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'No cache object matched the specified search'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'No such autofs map'

:: [   PASS   ] :: Running 'sss_cache -a auto.direct --debug 10 2> /tmp/cache_debugout'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'failed'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'No cache object matched the specified search'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'No such autofs map'

:: [   PASS   ] :: Running 'sss_cache -a auto.share1 --domain=LDAP --debug 10 2> /tmp/cache_debugout'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'failed'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'No cache object matched the specified search'
:: [   PASS   ] :: File '/tmp/cache_debugout' should not contain 'No such autofs map'

Comment 8 errata-xmlrpc 2013-02-21 09:43:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0508.html