Bug 894447

Summary: virsh domblkstat error with no message
Product: Red Hat Enterprise Linux 6 Reporter: Chris Evich <cevich>
Component: libvirtAssignee: Peter Krempa <pkrempa>
Status: CLOSED DUPLICATE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.5CC: acathrow, ajia, dyasny, dyuan, eblake, mzhan, rwu, ydu
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 889276 Environment:
Last Closed: 2013-01-14 13:52:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 889276    
Bug Blocks:    

Description Chris Evich 2013-01-11 18:50:14 UTC
+++ This bug was initially created as a clone of Bug #889276 +++

Description of problem:
When operating within the virsh shell (as opposed to executing single virsh command), error text is often printed with invalid commands or failed operations.  However, in one case the 'domblkstat' command does not print any error.  Although executing it as a single virsh command does exit(1).  This is a devition from it's RHEL 5 behavior where it does print an error message in both cases (command-line and in-shell).  The problem has to do with proper handling of empty-string arguments.

Version-Release number of selected component (if applicable):
0.9.10-21.el6_3.6

How reproducible:
100%

Steps to Reproduce:
1. virsh
2. virsh# domblkstat <name> ""
  
Actual results:
Blank line then 'virsh#' prompt is presented

Expected results:
Similar to RHEL 5, an error message is printed:

error: command 'domblkstat' requires <device> option

Additional info:
Bug discovered with libvirt autotest

Comment 2 Peter Krempa 2013-01-14 13:52:13 UTC

*** This bug has been marked as a duplicate of bug 889276 ***