Bug 894545

Created attachment 677297 [details]
Patch for rake 10.0.3

The issue you see with rawhide rubygem-rake (10.0.3) should be resolved with the attached patch.

Unfortunately now build fails with something related to ocaml:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4862774

make[2]: Leaving directory `/builddir/build/BUILD/libguestfs-1.21.2/perl/examples'
Making all in ocaml
make[2]: Entering directory `/builddir/build/BUILD/libguestfs-1.21.2/ocaml'
Makefile:1904: *** unterminated variable reference.  Stop.
make[2]: Leaving directory `/builddir/build/BUILD/libguestfs-1.21.2/ocaml'
make[1]: Leaving directory `/builddir/build/BUILD/libguestfs-1.21.2'
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.7Yr8hq (%build)
    Bad exit status from /var/tmp/rpm-tmp.7Yr8hq (%build)

However it seems I cannot reproduce this on local mockbuild??

Thanks -- setting NEEDINFO of me to look at this when I
get back from holiday later this week.

(In reply to comment #1)
> Created attachment 677297 [details]
> Patch for rake 10.0.3
> 
> The issue you see with rawhide rubygem-rake (10.0.3) should be resolved with
> the attached patch.

When I came to look at the attachment, I notice it doesn't
seem to contain the patch itself (just a patch applying
the unseen patch to libguestfs.spec).  Could you attach the
patch to this bug please.

> Unfortunately now build fails with something related to ocaml:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4862774
> 
> make[2]: Leaving directory
> `/builddir/build/BUILD/libguestfs-1.21.2/perl/examples'
> Making all in ocaml
> make[2]: Entering directory `/builddir/build/BUILD/libguestfs-1.21.2/ocaml'
> Makefile:1904: *** unterminated variable reference.  Stop.

I don't see this error.  And line 1904 in my ocaml/Makefile
seems innocuous.  I don't see how it could cause the error.
Do you have ocaml & ocaml-ocamlfind-devel installed?

(In reply to comment #3)
> (In reply to comment #1)
> > Created attachment 677297 [details]
> > Patch for rake 10.0.3
> > 
> > The issue you see with rawhide rubygem-rake (10.0.3) should be resolved with
> > the attached patch.
> 
> When I came to look at the attachment, I notice it doesn't
> seem to contain the patch itself (just a patch applying
> the unseen patch to libguestfs.spec).  Could you attach the
> patch to this bug please.

Please check
https://bugzilla.redhat.com/attachment.cgi?id=677297
not
https://bugzilla.redhat.com/attachment.cgi?id=677297&action=diff
(well, action=diff on bugzilla is not smart... I always see
 raw patch)

> > Unfortunately now build fails with something related to ocaml:
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=4862774
> > 
> > make[2]: Leaving directory
> > `/builddir/build/BUILD/libguestfs-1.21.2/perl/examples'
> > Making all in ocaml
> > make[2]: Entering directory `/builddir/build/BUILD/libguestfs-1.21.2/ocaml'
> > Makefile:1904: *** unterminated variable reference.  Stop.
> 
> I don't see this error.  And line 1904 in my ocaml/Makefile
> seems innocuous.  I don't see how it could cause the error.
> Do you have ocaml & ocaml-ocamlfind-devel installed?

As I wrote in comment 1, this is
http://koji.fedoraproject.org/koji/taskinfo?taskID=4862774 
http://kojipkgs.fedoraproject.org//work/tasks/2775/4862775/root.log
has ocaml & ocaml-ocamlfind-devel and
http://kojipkgs.fedoraproject.org//work/tasks/2775/4862775/build.log
contains this.

OK I've come up with a patch which appears to fix this,
while hopefully remaining backwards compatible:

https://github.com/libguestfs/libguestfs/commit/a0e9d310d1a2bd725c762a485f2b72761bac35df

I think my patch is more general than yours, since it should
allow this to work with ancient versions of ruby as well.  This
is a concern since we also build libguestfs on RHEL 5.

However for some reason I didn't need to do (the equivalent of)
this in my version:

+-Rake::RDocTask.new(:ri) do |rd|
++RDoc::Task.new(:ri) do |rd|

(In reply to comment #6)
> I think my patch is more general than yours, since it should
> allow this to work with ancient versions of ruby as well.  This
> is a concern since we also build libguestfs on RHEL 5.

Well, as libguestfs.spec already uses one F-17+ specific patch,
I thought I need not write so (anyway it is up to you)

> 
> However for some reason I didn't need to do (the equivalent of)
> this in my version:
> 
> +-Rake::RDocTask.new(:ri) do |rd|
> ++RDoc::Task.new(:ri) do |rd|

Oh, (I found that) rubygem-rdoc 3.12 still supports this (comment says "For backwards compatibility"), so for now Rake::RDocTask can be used. I think anyway trying RDoc::Task first is better, however this is also up to you.

(In reply to comment #1)
> Unfortunately now build fails with something related to ocaml:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4862774
> 
> make[2]: Leaving directory
> `/builddir/build/BUILD/libguestfs-1.21.2/perl/examples'
> Making all in ocaml
> make[2]: Entering directory `/builddir/build/BUILD/libguestfs-1.21.2/ocaml'
> Makefile:1904: *** unterminated variable reference.  Stop.
> make[2]: Leaving directory `/builddir/build/BUILD/libguestfs-1.21.2/ocaml'
> make[1]: Leaving directory `/builddir/build/BUILD/libguestfs-1.21.2'
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> RPM build errors:
> error: Bad exit status from /var/tmp/rpm-tmp.7Yr8hq (%build)
>     Bad exit status from /var/tmp/rpm-tmp.7Yr8hq (%build)
> 
> However it seems I cannot reproduce this on local mockbuild??

Now I see this as well ...  but same as you, only in Koji,
not in local builds on F19.  Looking into it.  It may be a
missing dependency.

This is a bug in automake.  I filed a bug which should
appear here at some point in the near future:

http://lists.gnu.org/archive/html/bug-automake/2013-01/threads.html

I've fixed the Ruby problem and the automake problem.  I'm
still trying to wrangle a build (there seem to be further
bugs) so libguestfs is still temporarily FTBFS on Rawhide,
but this bug at least has been fixed.

Should get a build working today ...

libguestfs-1.20.2-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libguestfs-1.20.2-5.fc18

libguestfs-1.20.2-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.