Bug 895592 (syntaxhighlighter)
| Summary: | Review Request: syntaxhighlighter - JavaScript syntax highlighter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting, package-review |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | syntaxhighlighter-3.0.83-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-06-27 01:53:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 895622 | ||
|
Description
Remi Collet
2013-01-15 15:38:29 UTC
Hmm...No javascript packaging guideline now, only a draft. From fedora-review seems OK, but somethings maybe you should fix: 1) I found that mixture of tab and space in License and Source0 tag. 2) This library has its GitHub page, and the author has tagged the 3.0.83 version. https://github.com/alexgorbatchev/SyntaxHighlighter/tags 3) Is this spec for EL only? I've seen many obsoleted lines and buildroot tag. 4) A little more blanks between sections. Not mandatory. 5) License: MIT or GPLv2. Why not "and"? (In reply to Christopher Meng from comment #1) > Hmm...No javascript packaging guideline now, only a draft. > > From fedora-review seems OK, but somethings maybe you should fix: > > 1) I found that mixture of tab and space in License and Source0 tag. Agree, will fix it > 2) This library has its GitHub page, and the author has tagged the 3.0.83 > version. > > https://github.com/alexgorbatchev/SyntaxHighlighter/tags Yes, but the github only provides the "sources" and we don't have (yet) needed stuff to run the build (npm, jake, ...) In fact, "master" use node.js stuff, while old release 3.0.83 use phing. I will look if we can build from source (it seems we need lot of fix because it use a very old version... of course... 2010) But don't know if it worth the work... as will be broken as soon as a new version will be released. Build for JS is mostly: concat + compress (result still readable) > 3) Is this spec for EL only? I've seen many obsoleted lines and buildroot > tag. This spec target EL-5, so yes buildroot, ... are required. > 4) A little more blanks between sections. Not mandatory. > > 5) License: MIT or GPLv2. Why not "and"? Because https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Dual_Licensing_Scenarios Build from github sources: https://github.com/remicollet/remirepo/commit/5f76f61988779c3f6a3e0099f8c464a26cddc95a Spec: https://raw.github.com/remicollet/remirepo/5f76f61988779c3f6a3e0099f8c464a26cddc95a/syntaxhighlighter/syntaxhighlighter.spec SRPM: http://rpms.famillecollet.com/SRPMS/syntaxhighlighter-3.0.83-2.remi.src.rpm Fix for EPEL-6 build https://github.com/remicollet/remirepo/commit/e288517d88ccea6525b8c9329133a6e8c8f8b9cd https://github.com/remicollet/remirepo/commit/7fbb189ab904b70a6c5d5a89d2190296b87e32f5 Koji scratch build dist-6E-epel http://koji.fedoraproject.org/koji/taskinfo?taskID=5508854 Spec: https://raw.github.com/remicollet/remirepo/7fbb189ab904b70a6c5d5a89d2190296b87e32f5/syntaxhighlighter/syntaxhighlighter.spec Srpm: http://rpms.famillecollet.com/SRPMS/syntaxhighlighter-3.0.83-2.remi.src.rpm cp %{SOURCE2} %{SOURCE3} .
should be:
cp -p %{SOURCE2} %{SOURCE3} .
And please preserve the ts when downloading these two licenses.
APPROVED.
Please FIX this problem before importing.
Plus, no need for %defattr(-,root,root,-), it's only needed < RPM 4.4 Thanks for the review. I will clean the EL-5 stuff after import (EL-5 is no more a target as phing is missing) New Package SCM Request ======================= Package Name: syntaxhighlighter Short Description: JavaScript syntax highlighter Owners: remi Branches: f18 f19 el6 InitialCC: Git done (by process-git-requests). syntaxhighlighter-3.0.83-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/syntaxhighlighter-3.0.83-2.fc18 syntaxhighlighter-3.0.83-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/syntaxhighlighter-3.0.83-2.el6 syntaxhighlighter-3.0.83-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/syntaxhighlighter-3.0.83-2.fc19 syntaxhighlighter-3.0.83-2.fc18 has been pushed to the Fedora 18 testing repository. syntaxhighlighter-3.0.83-2.fc18 has been pushed to the Fedora 18 stable repository. syntaxhighlighter-3.0.83-2.fc19 has been pushed to the Fedora 19 stable repository. syntaxhighlighter-3.0.83-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |