Bug 896025
| Summary: | curl_obj.reset() does not set up the default PYCURL_ERRORBUFFER | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Zdeněk Pavlas <zpavlas> | ||||||||
| Component: | python-pycurl | Assignee: | Kamil Dudka <kdudka> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 17 | CC: | jzeleny, keramidasceid, kklic | ||||||||
| Target Milestone: | --- | Keywords: | Patch | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | i686 | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | python-pycurl-7.19.0-14.fc19 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2013-03-02 19:58:59 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 832491 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Zdeněk Pavlas
2013-01-16 13:47:11 UTC
Created attachment 682231 [details]
Reinitialize PYCURL_ERRORBUFFER after reset
The CURL_ERRORBUFFER option is NOT supported by pycurl (it's not exposed in Python API). However, when a new handle is created, this option is set. The reset() method should be consistent, and reinitialize the CURL_ERRORBUFFER option.
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Created attachment 702502 [details]
upstream fix
The underlying problem is more general: all pycurl-specific defaults need to be reinitialized in reset(). The attached upstream patch fixes it.
Zdenek, could you please have a look at the patch before it goes to stable branches? Thanks in advance!
fixed in python-pycurl-7.19.0-14.fc19 Created attachment 702661 [details]
upstream fix V2
I have only removed a left-over global variable introduced by the upstream patch.
Yes, it's possible that pycurl defaults != curl defaults, and this should handle it nicely. ACK and thanks! Comment on attachment 702661 [details]
upstream fix V2
Thanks for review! I will submit updates for stable Fedora.
python-pycurl-7.19.0-11.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-pycurl-7.19.0-11.fc17 python-pycurl-7.19.0-13.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pycurl-7.19.0-13.fc18 Package python-pycurl-7.19.0-11.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-pycurl-7.19.0-11.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-3119/python-pycurl-7.19.0-11.fc17 then log in and leave karma (feedback). python-pycurl-7.19.0-13.fc18 fixes this bug I left positive karma at https://admin.fedoraproject.org/updates/F18/FEDORA-2013-3157 Thank you for the confirmation, Vasilis! python-pycurl-7.19.0-13.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. python-pycurl-7.19.0-13.1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pycurl-7.19.0-13.1.fc18 python-pycurl-7.19.0-11.1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-pycurl-7.19.0-11.1.fc17 python-pycurl-7.19.0-15.1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pycurl-7.19.0-15.1.fc19 python-pycurl-7.19.0-15.1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. python-pycurl-7.19.0-11.1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. python-pycurl-7.19.0-13.1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |