Bug 896033

Summary:	Review Request: lcab - Cabinet File Creation Tool
Product:	[Fedora] Fedora	Reporter:	Simone Caronni <negativo17>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mail, marcandre.lureau, notting, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-04 17:43:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Simone Caronni 2013-01-16 14:00:57 UTC

Spec URL: http://slaanesh.fedorapeople.org/lcab.spec
SRPM URL: http://slaanesh.fedorapeople.org/lcab-1.0b12-1.fc17.src.rpm
Description: LCAB is a small program for linux that creates an uncompressed MS Cabinet File from a set of input files.

Fedora Account System Username: slaanesh

==========

Note: planning to build for el5/el6/f17/f18/rawhide, so it contains rpm 4.5 macros.

Comment 1 Fabian Affolter 2013-01-20 13:04:01 UTC

Just some quick comments

- Please take a look at the guidelines about the numbering of Post-Release packages.
  https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages
- The COPYING file is missing in the %doc section
- There is also a man page in the source.

Comment 2 Simone Caronni 2013-01-21 08:45:04 UTC

Spec URL: http://slaanesh.fedorapeople.org/lcab.spec
SRPM URL: http://slaanesh.fedorapeople.org/lcab-1.0-0.2.b12.fc17.src.rpm

Thanks for the info, I updated everything. I've changed the first revision in the changelog to 0.1.b12 as well to keep it chronologically consistent.

Comment 3 Fabian Affolter 2013-02-04 09:59:31 UTC

*** Bug 826685 has been marked as a duplicate of this bug. ***

Comment 4 Fabian Affolter 2013-02-04 10:10:53 UTC

Can you please check your rpmlint output? There will be at least a warning about the license. According to the source it's GPLv2+.

Comment 5 Marc-Andre Lureau 2013-02-04 12:29:57 UTC

I would strongly recommend using gcab instead of lcab. lcab is poorly maintained, of low code quality, doesn't provide zip compression, nor translation.

otoh, gcab is a tool and library that provides both compression and decompression, using GLib/GIO, providing GIR bindings, has a handful of translations already, and hopefully of better source code quality.It is a dependency of msitools (so it will end up in Fedora sooner or later), and I am maintaining it, it is very much "alive".

Is there anything that lcab does that you need that gcab doesn't provide?

See request:
https://bugzilla.redhat.com/show_bug.cgi?id=895757

Comment 6 Simone Caronni 2013-02-04 17:43:12 UTC

(In reply to comment #5)
> Is there anything that lcab does that you need that gcab doesn't provide?
> 
> See request:
> https://bugzilla.redhat.com/show_bug.cgi?id=895757

Thanks for the information, I did not notice it while doing the search, I've tried it and it surely is much better than lcab.

I'm closing this review, I have no more interest in having lcab in Fedora.

I'm taking gcab for review.

Regards,
--Simone