Bug 896694

Summary:	AIO - should not ask to stop ovirt-engine service if not installed/running
Product:	[Retired] oVirt	Reporter:	Itamar Heim <iheim>
Component:	ovirt-engine-installer	Assignee:	Sandro Bonazzola <sbonazzo>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	acathrow, cybertimber2000, dyasny, iheim, oschreib, sbonazzo, ykaul
Target Milestone:	---
Target Release:	3.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	integration
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	904788 (view as bug list)		Environment:
Last Closed:	2013-02-15 06:47:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	881006, 904788

Description Itamar Heim 2013-01-17 19:15:03 UTC

when running engine-setup, the following prompt appears[1].
I'm not sure why this prompt is relevant at setup (rather than at upgrade).
in any case, no point showing it if there is no ovirt-engine service installed or running yet (i.e., I'm getting this at an install on a vanilla f18)

ovirt-engine-setup.noarch 0:3.2.0-1.20121212.git01e08b2.fc18

[1][root@f18 ~]# engine-setup 
Welcome to oVirt Engine setup utility

In order to proceed the installer must stop the ovirt-engine service
Would you like to stop the ovirt-engine service? (yes|no):

Comment 1 Sandro Bonazzola 2013-01-22 07:50:03 UTC

I think I can take care of this.

Comment 2 Sandro Bonazzola 2013-01-23 07:09:14 UTC

http://gerrit.ovirt.org/#/c/11276/

Comment 4 Sandro Bonazzola 2013-01-23 07:27:48 UTC

If the engine service is in state not running, and only in this
state, avoid to ask for stopping the service.
The script doesn't check for service up and running, avoiding a
regression on RHBZ #837812.
The script also avoid to stop the engine service if already stopped and not configured.

Comment 5 Sandro Bonazzola 2013-01-24 12:55:42 UTC

the patch was merged: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=b1da51482448ddabaa9b9f5c27c06188266d4e4a

Comment 6 Cybertimber2011 2013-02-04 17:12:19 UTC

I noted this behavior in ovirt-engine-setup version 3.2.0-2.fc18

[root@ovirt-engine-32 ~]# systemctl status ovirt-engine
ovirt-engine.service - oVirt Engine
          Loaded: loaded (/usr/lib/systemd/system/ovirt-engine.service; disabled)
          Active: inactive (dead)

Feb 04 11:26:38 localhost.localdomain systemd[1]: Stopped oVirt Engine.
Feb 04 11:59:16 localhost.localdomain systemd[1]: Stopped oVirt Engine.
Feb 04 12:01:33 localhost.localdomain systemd[1]: Stopped oVirt Engine.
[root@ovirt-engine-32 ~]# engine-setup
Welcome to oVirt Engine setup utility

In order to proceed the installer must stop the ovirt-engine service
Would you like to stop the ovirt-engine service? (yes|no):

[root@ovirt-engine-32 ~]# yum list | grep ovirt-engine-setup
ovirt-engine-setup.noarch               3.2.0-2.fc18                    @ovirt-beta
ovirt-engine-setup-plugin-allinone.noarch

Comment 7 Sandro Bonazzola 2013-02-05 07:12:55 UTC

Thanks for your testing. 
The patch is merged upstream in the master tree.
It is also pushed to the 3.2 branch but not yet merged: 
http://gerrit.ovirt.org/#/c/11706/