Bug 896735
Summary: | Please move /usr/share/images | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael Schwendt <bugs.michael> | ||||||
Component: | linphone | Assignee: | nucleo <alekcejk> | ||||||
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | low | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 23 | CC: | alekcejk, quentin, rakesh.pandit | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2016-12-20 12:33:11 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Michael Schwendt
2013-01-17 21:17:53 UTC
If you provide patch for mediastreamer to use other path for searching and installing nowebcamCIF.jpg then I can apply it. Talking with upstream linphone about this impossible because they don't have bugtracking system, all emails to mailing lists ignored (for example I asked help for FTBFS in rawhode and nobody answered, as always). Created attachment 680607 [details]
one way to change the path in ./mediastreamer2/src/ files
Here's what would need to be patch.
No contact with upstream isn't ideal, because it might become necessary to update the patch if the related source files changed drastically. It also means that one cannot negotiate about revised/enhanced versions of a patch. For example, one could use the $(PACKAGE_NAME) variable instead of hardcoding "linphone" in the same way the mediastreamer2/src/nowebcam.c file does, but it also does strange/fragile things like
#ifndef PACKAGE_DATA_DIR
#define PACKAGE_DATA_DIR "share"
#endif
which can lead to building in a path that differs from the actual location of the packaged files.
Created attachment 680608 [details]
optional patch for autotools rebuilds
This patch will only be needed if automake/autoreconf will be used to regenerate/rebuild Makefile.in files.
Thanks for the patches, I will look on them. Without upstream decision there is arbitrariness in selecting images path, it can be in %{_datadir}/linphone or maybe in %{_libdir}/medisatreamer because images is part of mediastreamer and %{_libdir}/medisatreamer/plugins is path where mediastreamer searches for plugins but this dir is not installed by 'make install'. linphone-mediastreamer can be installed without linphone this is reason why I don't whant use %{_datadir}/linphone/images dir, and use %{_libdir}/medisatreamer/images/. But for using %{_libdir}/medisatreamer/images/ path I can't find what variable should be used instead of PACKAGE_DATA_DIR. One of solutions is build separate mediastreamer package from this sources http://download-mirror.savannah.gnu.org/releases/linphone/mediastreamer/mediastreamer-2.8.2.tar.gz In this sources used configure file that differs from mediastremer in linphone sources because PACKAGE_DATA_DIR defined in linphone's configure. So I tried to change #define PACKAGE_DATA_DIR "${package_prefix}/share to #define PACKAGE_DATA_DIR "${datadir)" in medistreamers configure and built it with --datadir=%{_libdir}/mediastreamer. With bundled mediastreamer this don't work because there is no this #define. That's true. You can only use macros defined in config.h or the preprocessor options. There is no definition for LIBDIR yet. If you insist on storing the image(s) in %{_libdir}/mediastreamer/images, you could add "-DPACKAGE_MEDIASTREAMER_DATA_DIR=%{_libdir}/mediastreamer" to CFLAGS and CXXFLAGS in the spec file and patch the source to use that macro instead of PACKAGE_DATA_DIR. You could also reduce the solution to a simple packaging technique: patch the source to use something like __PACKAGE_MEDIASTREAMER_DATA_DIR__ instead of PACKAGE_DATA_DIR, and replace that special string of characters with e.g. a "sed" substitution inside the spec file's %prep section. I have filling that without ffmpeg file nowebcamCIF.jpg not used at all but I am not sure. At least I can find reference to images and this file in libmediastreamer.so.1.0.0 only if it built with ffmpeg (ffmpeg is mandatory for video calls support). This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This message is a reminder that Fedora 18 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 18. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '18'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 18's end of life. Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 18 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 18's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |