Bug 8985

Summary: startx fails if there's an xserverrc
Product: [Retired] Red Hat Linux Reporter: Hans de Goede <hdegoede>
Component: XFree86Assignee: Preston Brown <pbrown>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2000-02-01 21:09:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch which fixes the described problem. none

Description Hans de Goede 2000-01-30 16:08:52 UTC
The last line of startx is:
xinit $clientargs -- $display $serverargs

And if there's an xserverrc this is added as the first argument of
$serverargs. Causing the final command to be:
xinit foo -- :0 /etc/X11/xinit/xserverrc bar

After which X exists saying that /etc/X11/xinit/xserver rc isn't a valid
argument.

To fix this apply the following diff:
--- startx.orig Sun Jan 30 17:15:32 2000
+++ startx      Sun Jan 30 17:15:52 2000
@@ -19,9 +19,9 @@
 fi

 if [ -f $userserverrc ]; then
-    serverargs=$userserverrc
+    server=$userserverrc
 else if [ -f $sysserverrc ]; then
-    serverargs=$sysserverrc
+    server=$sysserverrc
 fi
 fi

@@ -63,7 +63,7 @@
 xauth add $display . $mcookie
 xauth add `hostname -f`$display . $mcookie

-xinit $clientargs -- $display $serverargs
+xinit $clientargs -- $server $display $serverargs

 # various machines need special cleaning up,
 # which should be done here
----

I've also attached this to the bugreport for your convience ;)

Comment 1 Hans de Goede 2000-01-30 16:09:59 UTC
Created attachment 83 [details]
patch which fixes the described problem.

Comment 2 Preston Brown 2000-02-01 21:09:59 UTC
will be fixed in XFree86-3.3.6-10.