Bug 900583 (JBPAPP6-945)

Summary: Installer: UI bug : Text fields do not persist the modified data and show blank as user clicks Next ,proceeds then returns back with previous
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Madhumita Sadhukhan <msadhukh>
Component: InstallerAssignee: Dustin Kut Moy Cheung <dcheung>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0CC: bgeorges, dcheung, msadhukh, pslavice, twells
Target Milestone: ---   
Target Release: EAP 6.0.1   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/JBPAPP6-945
Whiteboard: Installer
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-10-19 04:24:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 900726, 900727    
Attachments:
Description Flags
UIbug.png none

Description Madhumita Sadhukhan 2012-06-04 13:07:29 UTC
Affects: Release Notes
project_key: JBPAPP6

While running through the custom configuration for ports in installation process using Installers I found that if I modify some fields and click Next and later return to that page again to make some more changes the field shows blank in some cases.

This must be fixed as user loses the information .

For eg 

I added name for an optional field https.port in Socket Binding(standalone) and proceeded with Next.
When icame back to modify it again both the name and port fields showed balnk as seen in attached screenshot.
In this case user even loses port information which he never changed.
These textboxes should persist information onchanged.

Comment 1 Madhumita Sadhukhan 2012-06-04 13:08:13 UTC
Attachment: Added: UIbug.png


Comment 2 Dustin Kut Moy Cheung 2012-06-07 18:13:51 UTC
http://git.app.eng.bos.redhat.com/?p=izpack.git;a=commit;h=6c60d02baaa8af25e70836b6eeebf118c7d825ae
http://git.app.eng.bos.redhat.com/?p=jbossas-installer.git;a=commit;h=db1bdbb006438801d67781cb259a2d559bfe5366

[Detailed explanation of the fix]

The initial and final variables in those text fields were the same.

So $foo = initial variable = final variable

And the set (initial) value that is displayed is just the value of variable $foo. When you specify a different port number, $foo will be updated to take the specified port number. This does not cause any problems when you click Next, then Back again.

However, if you also specify a System Property value, $foo will then become ${sys-property:port-number}

Notice that if you do not specify a system property, $foo can be parsed to a number; however when specifying a system-propery, this is no more possible.


When specifying a system-property, then clicking Next and then Back, the port and system property disappear. This is because $foo is no more a number, and the port number field cannot validate $foo anymore.

The fix was to make initial variable != final variable. So if initial variable = $foo, final variable = $foo_final.


However, this means that $foo is no more updated, and when clicking back, even though $foo_final was updated to get the user-specified value, $foo will still show the default value and not the user defined one. To fix this, Izpack now also updates $foo with the user-specified value.




Comment 3 Dustin Kut Moy Cheung 2012-06-07 18:18:23 UTC
Labels: Added: Installer


Comment 4 Dustin Kut Moy Cheung 2012-07-23 14:52:08 UTC
Link: Added: This issue is a dependency of JBPAPP-9554


Comment 5 Dustin Kut Moy Cheung 2012-07-23 14:52:09 UTC
Link: Added: This issue is a dependency of JBPAPP-9555


Comment 6 Madhumita Sadhukhan 2012-10-01 09:24:21 UTC
text box inputs seem to be correctly updated in EAP 6.0.1.ER2 installer

Comment 7 Tom WELLS 2012-10-04 12:23:01 UTC
Does this need a release note for EAP 6.0.1? The issue needs to be re-opened if it does, and the release notes flags set (Affects Release Notes, Not Yet Documented).

Comment 8 Dana Mison 2012-10-08 01:17:37 UTC
reopening to add release notes info

Comment 9 Dana Mison 2012-10-08 01:20:02 UTC
Release Notes Docs Status: Added: Documented as Resolved Issue
Writer: Added: Darrin
Release Notes Text: Added: In the installation wizard, only a single variable was used to store both the default value displayed by each data entry field and the value entered by the user. If the user clicked "Back" on any stage of the wizard, the fields on the page would reset to the default values and the previously entered value would be lost. An additional variable has been added for each data entry field. The user entered data now correctly persists when the user navigates back and forward through the pages of the installation wizard.


Comment 10 Dana Mison 2012-10-08 01:20:41 UTC
documented as resolved for 6.0.1

Comment 11 Dana Mison 2012-10-19 04:24:43 UTC
Affects: Added: Release Notes


Comment 12 Madhumita Sadhukhan 2012-11-02 11:35:40 UTC
verified release notes

Comment 13 Anne-Louise Tangring 2012-11-13 20:07:52 UTC
Release Notes Docs Status: Removed: Documented as Resolved Issue 
Writer: Removed: Darrin 
Release Notes Text: Removed: In the installation wizard, only a single variable was used to store both the default value displayed by each data entry field and the value entered by the user. If the user clicked "Back" on any stage of the wizard, the fields on the page would reset to the default values and the previously entered value would be lost. An additional variable has been added for each data entry field. The user entered data now correctly persists when the user navigates back and forward through the pages of the installation wizard. 
Docs QE Status: Removed: NEW