Bug 901611
| Summary: | Review Request: atoum - PHP Unit Testing framework | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Johan Cwiklinski <fedora> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, notting, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-04-18 02:42:40 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Johan Cwiklinski
2013-01-18 16:02:44 UTC
Created attachment 684275 [details]
phpci.log
Created attachment 684276 [details]
php-atoum-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 901611
[!]: Requires correct, justified where necessary.
Missing: php-xml
Requires: /usr/bin/env instead of /usr/bin/php
=> fix the shebang in /usr/bin/atoum
[!]: %check is present and all tests pass.
%check
cd tests/units
echo "date.timezone=UTC" >php.ini
export PHPRC=$(pwd)/php.ini
php runner.php --directories .
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
Clean as other EL-5 stuff not present
[!]: License field in the package spec file matches the actual license.
COPYING file is BSD (3 clauses), not MIT
=> probably worth asking upstream to add a license "header" in all files
[!]: Package complies to the Packaging Guidelines
Non-PEAR PHP software which provides shared libraries should put its PHP source
files for such shared libraries in a subfolder of /usr/share/php.
=> this is not a library, so should rather use /usr/share/foo
(perhaps "classes" could go in /usr/share/php, which is in PHP include_path)
I miss this important one [!]: Package is named according to the Package Naming Guidelines. As this is not a library, "atoum" is the correct name. Here is th new version: Spec URL: http://odysseus.x-tnd.be/fedora/atoum/atoum.spec SRPM URL: http://odysseus.x-tnd.be/fedora/atoum/atoum-0-0.2.gitdbfb82f.fc18.src.rpm [x]: Requires correct, justified where necessary.
/usr/bin/php ok
php-xml ok
[x]: %check is present and all tests pass.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
[x]: License field in the package spec file matches the actual license.
BSD ok
[x]: Package complies to the Packaging Guidelines
/usr/share/atoum ok
[x]: Package is named according to the Package Naming Guidelines.
atoum ok
All issues fixed.
All seems fine now, no blocker
=== APPROVED ===
New Package SCM Request ======================= Package Name: atoum Short Description: PHP Unit Testing framework Owners: trasher Branches: f17 f18 InitialCC: Git done (by process-git-requests). atoum-0-0.2.gitdbfb82f.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/atoum-0-0.2.gitdbfb82f.fc17 atoum-0-0.2.gitdbfb82f.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/atoum-0-0.2.gitdbfb82f.fc18 atoum-0-0.2.gitdbfb82f.fc18 has been pushed to the Fedora 18 testing repository. atoum-0-0.2.gitdbfb82f.fc18 has been pushed to the Fedora 18 stable repository. atoum-0-0.2.gitdbfb82f.fc17 has been pushed to the Fedora 17 stable repository. |