Bug 902567

Summary:	Inventory task: Use lshw instead of libparted for retrieving disk information
Product:	[Retired] Beaker	Reporter:	Amit Saha <asaha>
Component:	tests	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dan Callaghan <dcallagh>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.9	CC:	aigao, dcallagh, ebaak, mcsontos, qwan, tools-bugs
Target Milestone:	21.0	Keywords:	FutureFeature, Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Inventory
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-26 06:18:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amit Saha 2013-01-22 00:48:46 UTC

Description of problem:

Currently the inventory task uses libparted (using ctypes) to retrieve disk information. Knowing the exact libparted version (for different distros) to load is a a trial and error operation and has led to trying a number of libparted libraries before one is found.


Using a solution such as 'lshw' eradicates that problem. Besides, it also falls in place with the move to 'lshw' for gathering other inventory data.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Amit Saha 2013-01-22 00:50:27 UTC

On Gerrit: http://gerrit.beaker-project.org/#/c/1659/

Comment 2 Marian Csontos 2013-01-22 09:08:35 UTC

Check it on s390 (and other platforms - ppc64?), please. I tried using lshw in the past and the output on s390 was far from complete.

Comment 4 Amit Saha 2014-06-11 08:22:44 UTC

Updated patch in http://gerrit.beaker-project.org/#/c/3139/

Comment 5 Amit Saha 2014-06-12 03:29:07 UTC

(In reply to Amit Saha from comment #4)
> Updated patch in http://gerrit.beaker-project.org/#/c/3139/

Separated out into it's own patch: http://gerrit.beaker-project.org/#/c/3141/

Comment 6 Amit Saha 2014-06-12 04:22:57 UTC

(In reply to Marian Csontos from comment #2)
> Check it on s390 (and other platforms - ppc64?), please. I tried using lshw
> in the past and the output on s390 was far from complete.

Yes indeed. We will  have to rectify that. Started off with this: http://gerrit.beaker-project.org/#/c/3142/2

Comment 7 Amit Saha 2014-06-22 10:46:31 UTC

lshw doesn't bring up anything with VirtIO disks

Comment 8 Amit Saha 2014-06-24 11:48:22 UTC

(In reply to Amit Saha from comment #7)
> lshw doesn't bring up anything with VirtIO disks

http://gerrit.beaker-project.org/#/c/3169/

Comment 9 Dan Callaghan 2015-07-24 00:44:29 UTC

We have virtio disks and IBM vio disks (bug 1212291) and S/390 DASD (bug 1212311) in lshw now, so I think we are in a good position to switch to using that instead of libparted.

Comment 10 Dan Callaghan 2015-07-24 01:45:32 UTC

http://gerrit.beaker-project.org/4312

Comment 13 Dan Callaghan 2015-07-27 04:14:22 UTC

It's an lshw bug: https://git.beaker-project.org/cgit/lshw/commit/?id=78bb0ffbecf3b0f7dfb7e7042c6eb59dbd540e1a
Filed upstream but it's still in the moderation queue.

Comment 15 Dan Callaghan 2015-08-26 06:18:09 UTC

Beaker 21.0 has been released.