Bug 902630

Summary:	Failed to reload openshift-broker service
Product:	OpenShift Container Platform	Reporter:	xjia <xjia>
Component:	Node	Assignee:	Luke Meyer <lmeyer>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	1.1.0	CC:	baulakh, bleanhar, jialiu, libra-onpremise-devel, mmasters, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	The openshift-broker reload script incorrectly expanded the $OPTIONS variable, which caused the following error: "Reloading openshift-broker: not reloading due to configuration syntax error". This fix adds eval, set, and "$@" to coax BASH into performing the expansion correctly. The openshift-broker service now reloads correctly.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-28 19:09:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description xjia 2013-01-22 06:17:35 UTC

Description of problem:
Reload openshift-broker service, it returns "
Reloading openshift-broker: not reloading due to configuration syntax error                                                           [FAILED]

Version-Release number of selected component (if applicable):
http://download.lab.bos.redhat.com/rel-eng/OpenShiftEnterprise/1.1/2013-01-17.1/

How reproducible:
Always

Steps to Reproduce:
1. Reload openshift-broker service
[root@broker init.d]# ./openshift-broker reload
2. Force-reload openshift-broker service

Actual results:
RESULT:
1.
[root@broker init.d]# ./openshift-broker reload
Reloading openshift-broker: not reloading due to configuration syntax error
                                                           [FAILED]
2.
[root@broker init.d]# service  openshift-broker force-reload
Reloading openshift-broker: not reloading due to configuration syntax error
                                                           [FAILED]

Expected results:
Success

Additional info:

Comment 4 Miciah Dashiel Butler Masters 2013-01-22 15:48:14 UTC

Here's one possible fix: https://github.com/openshift/origin-server/pull/1192

Comment 5 openshift-github-bot 2013-01-22 17:59:41 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/b23cd598c04154806456320929b50d04878b24c2
Bug 902630: fix `service openshift-broker reload`

In the initscript, the options to give to httpd are stored in the
$OPTIONS variable.  In the current version of the script, the status
action has an error that causes $OPTIONS to be expanded incorrectly.
This commit resolves the issue by using eval, set, and "$@" to coax BASH
into performing the expansion we want.

This commit also fixes an unrelated issue: The reload action did not
print anything on success, and now it will.

This commit should fix Bug 902630.

Comment 6 Miciah Dashiel Butler Masters 2013-01-22 19:24:43 UTC

Note that the above fix has been merged into origin-server, but not into enterprise-server.

Comment 7 Brenton Leanhardt 2013-01-31 13:05:49 UTC

This fix shipped in the last puddle:
http://buildvm-devops.usersys.redhat.com/puddle/build/OpenShiftEnterprise/1.1.x/2013-01-29.1/

Comment 8 Johnny Liu 2013-01-31 14:00:28 UTC

Verified this bug with 1.1.x/2013-01-29.1 puddle, and PASS.

# /etc/init.d/openshift-broker reload
Reloading openshift-broker:                                [  OK  ]

Comment 10 errata-xmlrpc 2013-02-28 19:09:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0582.html