Bug 903285 (python-viper)

Summary:	Review Request: python-viper - A minimalistic scientific plotter and run-time visualization module
Product:	[Fedora] Fedora	Reporter:	Jonathan Underwood <jonathan.underwood>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bnrj.rudra, i, mail, notting, package-review, volker27
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-03-06 10:55:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jonathan Underwood 2013-01-23 16:18:39 UTC

Spec URL: http://fedorapeople.org/~jgu/python-viper.spec
SRPM URL: http://fedorapeople.org/~jgu/python-viper-1.0.0-0.2.fc19.src.rpm
Description: 
A simple mesh plotter and run-time visualization module for plotting and
saving simulation data. The class C{Viper} can visualize solutions given as
numpy arrays, and meshes that provide the two methods C{cells()} and
C{coordinates()}. These methods should return numpy arrays specifying the
node-element ordering and coordinates of the nodes, respectively.


Fedora Account System Username: jgu

Comment 1 Jonathan Underwood 2013-01-23 16:20:57 UTC

Previously this was submitted for review as BZ 693158 but an overly officious review decided to be obstructive and close that bug when the original submitter didn't respond.

Comment 2 Jonathan Underwood 2013-01-23 16:21:52 UTC

*** Bug 693158 has been marked as a duplicate of this bug. ***

Comment 3 RudraB 2013-01-28 13:14:30 UTC

Hi Jonathan,
this is an unofficial review. 
I found one  problem with your submission.

In your spec, you declared the code as LGPLv2+
but your COPYING file includes GPLv3.
You may want to correct it.

Comment 4 Volker Fröhlich 2013-01-28 13:24:37 UTC

https://bugzilla.redhat.com/show_bug.cgi?id=693158#c3

It's not the license file that counts. licensecheck is your friend here.

Comment 5 RudraB 2013-01-28 13:48:50 UTC

oops...I found my mistake and sorry. withdrawing the revision.
Sorry Jonathan

Comment 6 Fabian Affolter 2013-03-05 19:01:16 UTC

The website says: "Viper is no longer being maintained. VTK-based plotting is now incorporated directly DOLFIN from version 1.1."

Comment 7 Jonathan Underwood 2013-03-06 10:55:03 UTC

Ah yes, so it does. I guess we can close this review in that case.