Bug 903288
| Summary: | use -fno-strict-aliasing cflag to fix some compilation warnings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> | ||||||
| Component: | fontforge | Assignee: | Kevin Fenzi <kevin> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | fonts-bugs, kevin, paul, pnemade | ||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | fontforge-20120731b-9.fc21 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-11-28 05:54:03 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Seems fine to me... rawhide only? Might submit upstream as well? Actually I need this fix for f18 also. I see that upstream sourcecode on github has been changed a lot and Makefiles are re-written and accepting additional compiler flags correctly. so no need to upstream this patch. Created attachment 788781 [details]
Modified spec file to address some issues
Issues that this patch will solve
1) bogus date changelog messages
2) adds cflag -Wstrict-aliasing
3) Fix compile time po files link error messages by removing makefile rule
e.g. some of these messages in build.log
ln -s ./po/*.po po
ln: failed to create symbolic link 'po/ca.po': File exists
ln: failed to create symbolic link 'po/de.po': File exists
ln: failed to create symbolic link 'po/el.po': File exists
ln: failed to create symbolic link 'po/en_GB.po': File exists
4) Fix compile time install error messages by removing makefile rule
/usr/bin/install: cannot stat './htdocs/flags/*': No such file or directory
make[1]: [install_docs] Error 1 (ignored)
/usr/bin/install: cannot stat './htdocs/ja/*': No such file or directory
make[1]: [install_docs] Error 1 (ignored)
can this patch be applied to master please? I went to apply this and then realized that I didn't approve your acls on the package. ;) Must have missed when you applied. I have approved them, can you apply this yourself? Or would you like me to? Thank you for approving my acls. I will commit now proposed spec file patch and build new package. Fixed in fontforge-20120731b-9.fc21. Closing this bug now. I just come to know to fix warning messages given in description comment I should have used cflag -fno-strict-aliasing and not -Wstrict-aliasing. Also, tested successfully rpmdiff results for this -fno-strict-aliasing cflag. Sorry I got confused in between as I was actually decided to use -fno-strict-aliasing but then something made me to change it to -Wstrict-aliasing. I will build new package tomorrow. This is already fixed in fontforge-20120731b-10.fc21 |
Created attachment 686075 [details] add -fno-strict-aliasing to every needed Makefile Description of problem: I see fontforge build.log showing ufo.c:1027:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] ufo.c:1031:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] spec file shows -fno-strict-aliasing added to CFLAGS but its not in effect. Attached patch will modify each needed Makefile to add that flag Also, attached patch removes some makefile rules as they are really not needed Version-Release number of selected component (if applicable): fontforge-20120731b-2.fc18.x86_64 How reproducible: always Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: