Bug 903328

Summary: [patches] rdesktop fails to connect to Windows Terminal Server 2008 Session Broker with Load Balance enabled
Product: [Fedora] Fedora Reporter: Charles R. Anderson <cra>
Component: rdesktopAssignee: Jon Disnard <jdisnard>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: cra, dominik, kem
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: http://sourceforge.net/p/rdesktop/patches/214/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 14:41:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
wts 2008 reinit sec layer for redirect
none
wts 2008 redirect pdu handling reworked none

Description Charles R. Anderson 2013-01-23 18:34:20 UTC
Description of problem:

There are a few bugs that make it not possible to connect to a Windows Terminal Server 2008 Session Broker with Load Balance enabled:

http://sourceforge.net/p/rdesktop/bugs/311/?page=0

Version-Release number of selected component (if applicable):
rdesktop-1.7.1-1.fc18

How reproducible:
always

Steps to Reproduce:
1. rdesktop to a WTS 2008 server with Load Balance enabled
  
Actual results:

Stuck at Welcome to Windows, or stuck at a black screen, and/or one of the following error messages in the terminal where rdesktop was started:

WARNING: Unexpectedly large redirection cookie
WARNING: PDU_REDIRECT_DONT_STORE_USERNAME set
WARNING: PDU_REDIRECT_USE_SMARTCARD set
WARNING: PDU_REDIRECT_INFORMATIONAL set
ERROR: recv: Connection reset by peer
ERROR: send: Broken pipe

Expected results:

No errors, successful connection to WTS 2008.

Additional info:

Comment 1 Charles R. Anderson 2013-01-23 18:35:52 UTC
Created attachment 686142 [details]
wts 2008 reinit sec layer for redirect

Patches available here and attached to this bug:

http://sourceforge.net/p/rdesktop/patches/214/

Comment 2 Charles R. Anderson 2013-01-23 18:36:54 UTC
Created attachment 686144 [details]
wts 2008 redirect pdu handling reworked

Hello devs,

Please find attached two patches which make rdesktop 1.7.1 work with Windows Terminal Server 2008 Session Broker with Load Balance enabled.
the rdesktop-1.7.1-wts2008-loadbalance.patch reworks the redirect pdu handling accordign to Microsoft docs at:
http://msdn.microsoft.com/en-us/library/ee443575%28prot.20%29.aspx [ 2.2.13.1 Server Redirection Packet (RDP_SERVER_REDIRECTION_PACKET) ]
the rdesktop-1.7.1-wts2008-reinitsec.patch adds reinitialization of a g_licence_issued global variable - wihout it wts 2008 server presents a black or 'welcome' screen after redirect - but refuses to talk to the client ...
As far as I can tell (and after testing) rdesktop 1.7.1 with above patches processes correctly session redirection with both Windows 2003 Server and Windows 2008 Server terminal servers.

Cheers
Jarek

Comment 3 Charles R. Anderson 2013-01-23 18:38:45 UTC
I applied these patches to 1.7.1 and they fix this problem for me.  Can you please apply these to 1.7.1 and push updates for rawhide/F19, F18, and F17?

Thanks,
Chuck

Comment 4 Fedora End Of Life 2013-04-03 17:32:02 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 5 Charles R. Anderson 2013-07-09 20:53:25 UTC
Ping?  After upgrading to Fedora 19, I have to build my own rdesktop with these patches so I can use it at work.  Can the maintainer please respond with a status update?  I'm happy to co-maintain if desired.  Thanks.

Comment 6 Dominik 'Rathann' Mierzejewski 2013-08-14 22:29:31 UTC
Charles, I updated rdesktop to 1.8.0, which was released recently. Please check if it fixes your issues.

https://admin.fedoraproject.org/updates/rdesktop-1.8.0-1.fc19

Comment 7 Dominik 'Rathann' Mierzejewski 2013-12-25 19:00:20 UTC
Please check if the update to 1.8.1 works for you.
https://admin.fedoraproject.org/updates/FEDORA-2013-23911

Comment 8 Charles R. Anderson 2013-12-26 21:42:14 UTC
I had built 1.8.1 myself, and it does not fix the issue.  Additionally, the patches no longer apply because they rewrote the session negitiation code.  According to the upstream bug report, this problem should be fixed in the latest source, which should make its way into a 1.8.2 release.

Comment 9 Dominik 'Rathann' Mierzejewski 2014-05-21 13:25:28 UTC
Please check if the latest 1.8.2 build from koji fixes things for you:
https://koji.fedoraproject.org/koji/buildinfo?buildID=517973

Comment 10 Charles R. Anderson 2014-11-06 17:51:17 UTC
The 1.8.2 build works, although it has the same glitches that 1.7.1+redir patches.  Namely, you have to log in twice--after the first login, you get redirected to another login screen.  After the second login, everything works fine.

So I would say 1.8.2 is a definite improvement over 1.8.1.  I see that 1.8.3 is now out, maybe that is even better.

Comment 11 Charles R. Anderson 2014-11-06 18:08:20 UTC
I rebuilt the f22 build of 1.8.3 on f19, and verified that it works great.  No double-login prompt on the TS cluster, the first login works fine and presents a working desktop.

Comment 12 Charles R. Anderson 2014-11-06 18:35:55 UTC
Oh well, the double-login thing came back.  So 1.8.3 is no worse than 1.7.1+redir patches.  I also verified that 1.8.3 works with the vinagre gui front end.

Comment 13 Fedora End Of Life 2015-01-09 17:36:25 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 14 Fedora End Of Life 2015-02-17 14:41:54 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.