Bug 903573

Summary:	need to sanitize initial environment
Product:	[Fedora] Fedora	Reporter:	Michal Schmidt <mschmidt>
Component:	systemd	Assignee:	systemd-maint
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	18	CC:	johannbg, lnykryn, metherid, msekleta, notting, plautrba, systemd-maint, vpavlin, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	systemd-201-2.fc18.6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-05-16 02:57:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michal Schmidt 2013-01-24 10:30:58 UTC

A reproducible crash was reported by BogdanR in #systemd. I investigated and pointed to the trigger: invalid UTF-8 sequences in PID1's environment in Bogdan's setup.

I can reproduce it in F18:
1. Add "<some-non-UTF8-garbage>=<whatever>" to the kernel command line in grub.conf.
2. Reboot. (Don't enter GRUB's editor, or it will replace the garbage with ASCII '?' marks.)
3. (Optional) Verify the garbage got passed:
   xxd /proc/cmdline
   xxd /proc/1/environ
4. systemctl show-environment

systemd hits an assertion check in libdbus (passing a non-UTF8 string to DBus).

Comment 1 Lennart Poettering 2013-02-12 15:36:24 UTC

Fixed in git.

Comment 2 Fedora Update System 2013-04-10 20:11:21 UTC

systemd-201-2.fc18.1 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/systemd-201-2.fc18.1

Comment 3 Fedora Update System 2013-04-11 23:24:14 UTC

Package systemd-201-2.fc18.2:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-201-2.fc18.2'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5452/systemd-201-2.fc18.2
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-04-15 23:58:49 UTC

Package systemd-201-2.fc18.4:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-201-2.fc18.4'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5452/systemd-201-2.fc18.3
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2013-04-18 02:36:09 UTC

Package systemd-201-2.fc18.5:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-201-2.fc18.5'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5452/systemd-201-2.fc18.5
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-05-07 13:38:40 UTC

systemd-201-2.fc18.6 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/FEDORA-2013-5452/systemd-201-2.fc18.6

Comment 7 Fedora Update System 2013-05-09 10:01:19 UTC

Package systemd-201-2.fc18.6:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-201-2.fc18.6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5452/systemd-201-2.fc18.6
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-05-16 02:57:23 UTC

systemd-201-2.fc18.6 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.